Skip to content

Commit

Permalink
run lint on CI, in addition to locally
Browse files Browse the repository at this point in the history
  • Loading branch information
timkpaine committed May 5, 2022
1 parent f8ec8b5 commit 64444bd
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 7 deletions.
14 changes: 13 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,16 @@ jobs:
run: |
npm install
npm run lint-check
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.9'
architecture: 'x64'
- name: Install with dependencies
shell: bash -l {0}
run: pip install -e ".[test]"
- name: lint python
shell: bash -l {0}
run: |
black --check ipycytoscape setup.py docs/source/conf.py
flake8 ipycytoscape setup.py docs/source/conf.py
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: [3.7, 3.8, 3.9]

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ repos:
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: 21.12b0
rev: 22.1.0
hooks:
- id: black
- repo: https://github.com/asottile/pyupgrade
Expand Down
11 changes: 7 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,16 @@
],
extras_require={
"test": [
"pytest>4.6",
"pytest-cov",
"nbval",
"pandas",
"black==22.1.0",
"flake8>=4.0.1",
"flake8-typing-imports>=1.7.0",
"nbclassic>=0.2.8",
"nbval",
"networkx",
"pandas",
"pre-commit",
"pytest>4.6",
"pytest-cov",
],
"examples": [
"pandas",
Expand Down

0 comments on commit 64444bd

Please sign in to comment.