Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrades http-proxy to prevent closed socket crash #29453

Conversation

JamesNimlos
Copy link

Additional details

  • If the socket is not open the write will fail and crash the server and cypress.

Steps to test

Reproduction steps are not concrete as this type of issue happens sporadically. This is a temporary validation of the changes introduced in cypress-io/node-http-proxy#1 to confirm they do not break existing proxy functionality and tests.

How has the user experience changed?

N/A

PR Tasks

If the socket is not open the write will fail and
crash the server and cypress.
@CLAassistant
Copy link

CLAassistant commented May 1, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@JamesNimlos We talked a bit internally about using patch-package to just move all of the changes made from the branched http-proxy repo we have including this change. This was just a very old repo branch. If you're open to doing that work, that would get this in a better state than the stale repo branch we have. Explanation of patch-package:

3. Patch the package using the [`patch-package`](https://github.com/ds300/patch-package#readme) utility on install/build

@AtofStryker
Copy link
Contributor

Hi @JamesNimlos! Thank you for opening a pull request. What we have decided to do as a team is patch the http-proxy package instead of continuing to maintain a fork. I have taken the changes in cypress-io/node-http-proxy#1 and applied them in #29499. I am going to close both requests in favor of #29499.

@AtofStryker AtofStryker closed this May 9, 2024
@JamesNimlos JamesNimlos deleted the issue-27552-upgrade-to-fix-socket-closed-crash branch May 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress crashes with "Error: This socket has been ended by the other party" at unpredictable times
5 participants