Skip to content

Commit

Permalink
chore: update RWA to node 18
Browse files Browse the repository at this point in the history
  • Loading branch information
AtofStryker committed Sep 1, 2023
1 parent 79afc2c commit 40e56c3
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ orbs:
executors:
with-chrome-and-firefox:
docker:
- image: "cypress/browsers:node16.16.0-chrome105-ff104-edge"
- image: "cypress/browsers-internal:node18.15.0-chrome114-ff115"
resource_class: large
environment:
PERCY_TOKEN:
Expand Down Expand Up @@ -40,16 +40,16 @@ commands:
at: ~/

# Setup Windows
# 1. Add nvm and install node 16.16.0
# 1. Add nvm and install node 18.15.0
# 2. Install yarn
setup_node_and_yarn_windows:
steps:
- run:
name: Install node 16
command: nvm install 16.16.0
name: Install node 18
command: nvm install 18.15.0
- run:
name: Use node 16
command: nvm use 16.16.0
name: Use node 18
command: nvm use 18.15.0
- run:
name: Install yarn
command: npm i --location=global yarn
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
install:
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
image: cypress/browsers-internal:node18.15.0-chrome114-ff115
options: --user 1001
steps:
- name: Checkout
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
# which has some compatibility issues with openSSL inside this windows job.
# Node 18 updated with OpenSSL provider which causes this compatibility issue
# downgrading node to v16 to use the openssl-legacy-provider by default to prevent this issue
node-version: '16.16.0'
node-version: '18.15.0'

- name: Cypress install
uses: cypress-io/github-action@v5
Expand All @@ -71,7 +71,7 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
image: cypress/browsers-internal:node18.15.0-chrome114-ff115
options: --user 1001
needs: install
strategy:
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
image: cypress/browsers-internal:node18.15.0-chrome114-ff115
options: --user 1001
needs: install
strategy:
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
image: cypress/browsers-internal:node18.15.0-chrome114-ff115
options: --user 1001
needs: install
strategy:
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
container:
image: cypress/browsers:node16.16.0-chrome105-ff104-edge
image: cypress/browsers-internal:node18.15.0-chrome114-ff115
options: --user 1001
needs: install
strategy:
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:
uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.16.0'
node-version: '18.15.0'

- name: Download the build folders
uses: actions/download-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
18.15.0
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
18.15.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"url": "https://github.com/cypress-io/cypress-realworld-app/issues"
},
"engines": {
"node": "^16.16.0"
"node": "^18.15.0"
},
"dependencies": {
"@auth0/auth0-react": "2.1.1",
Expand Down

0 comments on commit 40e56c3

Please sign in to comment.