-
Notifications
You must be signed in to change notification settings - Fork 393
Add node 22, chrome 134, and ff138 images for base-internal and browsers-internal #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
6
commits into
master
Choose a base branch
from
node-22.14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
054a18a
node 22 base/browser internal images
cacieprins 37baeec
prettier
cacieprins 3415d53
Update package.json
cacieprins f955f46
comma
cacieprins e980da3
revert prettier changes to ./README
cacieprins 52327a1
\n
cacieprins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
base-internal/releases/node-22/22.14.0-bullseye/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # build it with command | ||
| # docker build -t cypress/base-internal:22.14.0-bullseye --platform linux/amd64 . | ||
| # | ||
| FROM node:22.14.0-bullseye-slim | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install --no-install-recommends -y \ | ||
| libgtk2.0-0 \ | ||
| libgtk-3-0 \ | ||
| libnotify-dev \ | ||
| libgconf-2-4 \ | ||
| libgbm-dev \ | ||
| libnss3 \ | ||
| libxss1 \ | ||
| libasound2 \ | ||
| libxtst6 \ | ||
| procps \ | ||
| xauth \ | ||
| xvfb \ | ||
| build-essential \ | ||
| # install text editors | ||
| vim-tiny \ | ||
| nano \ | ||
| # install emoji font | ||
| fonts-noto-color-emoji \ | ||
| # install Chinese fonts | ||
| # this list was copied from https://github.com/jim3ma/docker-leanote | ||
| fonts-arphic-bkai00mp \ | ||
| fonts-arphic-bsmi00lp \ | ||
| fonts-arphic-gbsn00lp \ | ||
| fonts-arphic-gkai00mp \ | ||
| fonts-arphic-ukai \ | ||
| fonts-arphic-uming \ | ||
| ttf-wqy-zenhei \ | ||
| ttf-wqy-microhei \ | ||
| xfonts-wqy \ | ||
| # clean up | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean | ||
|
|
||
| USER root | ||
|
|
||
| RUN node --version | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update && \ | ||
| apt-get install -y \ | ||
| fonts-liberation \ | ||
| git \ | ||
| libcurl4 \ | ||
| libcurl3-gnutls \ | ||
| libcurl3-nss \ | ||
| libvulkan1 \ | ||
| xdg-utils \ | ||
| wget \ | ||
| # needed for circle orb browsers to install firefox | ||
| gpg \ | ||
| # needed for circle orb browsers to install chromedriver | ||
| jq \ | ||
| curl \ | ||
| # chrome dependencies | ||
| libu2f-udev \ | ||
| # firefox dependencies | ||
| bzip2 \ | ||
| # add codecs needed for video playback in firefox | ||
| # https://github.com/cypress-io/cypress-docker-images/issues/150 | ||
| mplayer \ | ||
| \ | ||
| # clean up | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean | ||
|
|
||
| # install libappindicator3-1 - not included with Debian 11 | ||
| RUN wget --no-verbose /usr/src/libappindicator3-1_0.4.92-7_amd64.deb "http://ftp.us.debian.org/debian/pool/main/liba/libappindicator/libappindicator3-1_0.4.92-7_amd64.deb" && \ | ||
| dpkg -i /usr/src/libappindicator3-1_0.4.92-7_amd64.deb ; \ | ||
| apt-get install -f -y && \ | ||
| rm -f /usr/src/libappindicator3-1_0.4.92-7_amd64.deb | ||
|
|
||
| # a few environment variables to make NPM installs easier | ||
| # good colors for most applications | ||
| ENV TERM=xterm | ||
| # avoid million NPM install messages | ||
| ENV npm_config_loglevel=warn | ||
|
|
||
| RUN npm --version \ | ||
| && npm install -g yarn@latest --force \ | ||
| && yarn --version \ | ||
| && node -p process.versions \ | ||
| && node -p 'module.paths' \ | ||
| && echo " node version: $(node -v) \n" \ | ||
| "npm version: $(npm -v) \n" \ | ||
| "yarn version: $(yarn -v) \n" \ | ||
| "debian version: $(cat /etc/debian_version) \n" \ | ||
| "user: $(whoami) \n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| docker build -t cypress/base-internal:22.14.0-bullseye --platform linux/amd64 . |
68 changes: 68 additions & 0 deletions
68
base-internal/releases/node-22/22.14.0-yarn-berry/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # build it with command | ||
| # docker build -t cypress/base-internal:22.14.0-yarn-berry --platform linux/amd64 . | ||
| # | ||
| FROM node:22.14.0-bookworm-slim | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install --no-install-recommends -y \ | ||
| libgtk2.0-0 \ | ||
| libgtk-3-0 \ | ||
| libnotify-dev \ | ||
| libgconf-2-4 \ | ||
| libgbm-dev \ | ||
| libnss3 \ | ||
| libxss1 \ | ||
| libasound2 \ | ||
| libxtst6 \ | ||
| procps \ | ||
| xauth \ | ||
| xvfb \ | ||
| build-essential \ | ||
| # install text editors | ||
| vim-tiny \ | ||
| nano \ | ||
| wget \ | ||
| curl \ | ||
| git \ | ||
| # install emoji font | ||
| fonts-noto-color-emoji \ | ||
| # install Chinese fonts | ||
| # this list was copied from https://github.com/jim3ma/docker-leanote | ||
| fonts-arphic-bkai00mp \ | ||
| fonts-arphic-bsmi00lp \ | ||
| fonts-arphic-gbsn00lp \ | ||
| fonts-arphic-gkai00mp \ | ||
| fonts-arphic-ukai \ | ||
| fonts-arphic-uming \ | ||
| ttf-wqy-zenhei \ | ||
| ttf-wqy-microhei \ | ||
| xfonts-wqy \ | ||
| # clean up | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install --no-install-recommends -y \ | ||
| ca-certificates | ||
|
|
||
| # a few environment variables to make NPM installs easier | ||
| # good colors for most applications | ||
| ENV TERM=xterm | ||
| # avoid million NPM install messages | ||
| ENV npm_config_loglevel=warn | ||
| # allow installing when the main user is root | ||
| ENV npm_config_unsafe_perm=true | ||
| # need to enable corepack to set yarn version | ||
| RUN corepack enable | ||
| # set the yarn version to 4 to get yarn berry, which does not install modules into node_modules | ||
| RUN yarn set version 4.3.1 | ||
|
|
||
| RUN npm --version \ | ||
| && yarn --version \ | ||
| && node -p process.versions \ | ||
| && node -p 'module.paths' \ | ||
| && echo " node version: $(node -v) \n" \ | ||
| "npm version: $(npm -v) \n" \ | ||
| "yarn version: $(yarn -v) \n" \ | ||
| "debian version: $(cat /etc/debian_version) \n" \ | ||
| "user: $(whoami) \n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| docker build -t cypress/base-internal:22.14.0-yarn-berry --platform linux/amd64 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # build it with command | ||
| # docker build -t cypress/base-internal:22.14.0 --platform linux/amd64 . | ||
| # | ||
| FROM node:22.14.0-bookworm-slim | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install --no-install-recommends -y \ | ||
| libgtk2.0-0 \ | ||
| libgtk-3-0 \ | ||
| libnotify-dev \ | ||
| libgconf-2-4 \ | ||
| libgbm-dev \ | ||
| libnss3 \ | ||
| libxss1 \ | ||
| libasound2 \ | ||
| libxtst6 \ | ||
| procps \ | ||
| xauth \ | ||
| xvfb \ | ||
| build-essential \ | ||
| # install text editors | ||
| vim-tiny \ | ||
| nano \ | ||
| # install emoji font | ||
| fonts-noto-color-emoji \ | ||
| # install Chinese fonts | ||
| # this list was copied from https://github.com/jim3ma/docker-leanote | ||
| fonts-arphic-bkai00mp \ | ||
| fonts-arphic-bsmi00lp \ | ||
| fonts-arphic-gbsn00lp \ | ||
| fonts-arphic-gkai00mp \ | ||
| fonts-arphic-ukai \ | ||
| fonts-arphic-uming \ | ||
| ttf-wqy-zenhei \ | ||
| ttf-wqy-microhei \ | ||
| xfonts-wqy \ | ||
| # clean up | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean | ||
|
|
||
| # a few environment variables to make NPM installs easier | ||
| # good colors for most applications | ||
| ENV TERM=xterm | ||
| # avoid million NPM install messages | ||
| ENV npm_config_loglevel=warn | ||
|
|
||
| RUN npm --version \ | ||
| && npm install -g yarn@latest --force \ | ||
| && yarn --version \ | ||
| && node -p process.versions \ | ||
| && node -p 'module.paths' \ | ||
| && echo " node version: $(node -v) \n" \ | ||
| "npm version: $(npm -v) \n" \ | ||
| "yarn version: $(yarn -v) \n" \ | ||
| "debian version: $(cat /etc/debian_version) \n" \ | ||
| "user: $(whoami) \n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| docker build -t cypress/base-internal:22.14.0 --platform linux/amd64 . |
45 changes: 45 additions & 0 deletions
45
browsers-internal/releases/node-22/node22.14.0-bullseye-chrome134-ff138-edge/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # build this image with command | ||
| # docker build -t cypress/browsers-internal:node22.14.0-bullseye-chrome134-ff138-edge --platform linux/amd64 . | ||
| # | ||
|
|
||
| FROM cypress/browsers-internal:node22.14.0-bullseye-chrome134-ff138 | ||
|
|
||
| USER root | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update && \ | ||
| apt-get install -y \ | ||
| # edge dependencies | ||
| gnupg \ | ||
| dirmngr \ | ||
| \ | ||
| # clean up | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean | ||
|
|
||
| # install latest Edge | ||
| RUN node -p "process.arch === 'arm64' ? 'Not downloading Edge since we are on arm64: https://techcommunity.microsoft.com/t5/discussions/edge-for-linux-arm64/m-p/1532272' : process.exit(1)" || \ | ||
| (curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg && \ | ||
| install -o root -g root -m 644 microsoft.gpg /etc/apt/trusted.gpg.d/ && \ | ||
| sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/repos/edge stable main" > /etc/apt/sources.list.d/microsoft-edge-dev.list' && \ | ||
| rm microsoft.gpg && \ | ||
| ## Install Edge | ||
| apt-get update && \ | ||
| apt-get install -y microsoft-edge-dev && \ | ||
| ## Add a link to the browser that allows Cypress to find it | ||
| ln -s /usr/bin/microsoft-edge /usr/bin/edge) | ||
|
|
||
| # install pnpm | ||
| RUN npm install -g pnpm@9 --force | ||
|
|
||
| # versions of local tools | ||
| RUN echo " node version: $(node -v) \n" \ | ||
| "npm version: $(npm -v) \n" \ | ||
| "yarn version: $(yarn -v) \n" \ | ||
| "pnpm version: $(pnpm -v) \n" \ | ||
| "debian version: $(cat /etc/debian_version) \n" \ | ||
| "Chrome version: $(google-chrome --version) \n" \ | ||
| "Firefox version: $(firefox --version) \n" \ | ||
| "Edge version: $(edge --version) \n" \ | ||
| "git version: $(git --version) \n" \ | ||
| "whoami: $(whoami) \n" |
21 changes: 21 additions & 0 deletions
21
...s-internal/releases/node-22/node22.14.0-bullseye-chrome134-ff138-edge/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # cypress/browsers-internal:node22.14.0-bullseye-chrome134-ff138-edge | ||
|
|
||
| A complete image with all operating system dependencies for Cypress, and Chrome 134.0.6998.165-1, Firefox 138.0, and Microsoft Edge browsers. | ||
|
|
||
| NOTE: This image is intended for internal use with https://github.com/cypress-io/cypress. It contains a few differences from the factory, such as: | ||
|
|
||
| #### Dependency Additions | ||
|
|
||
| - curl | ||
| - build-essentials (to contain `make` and a few other dependencies) | ||
| - pnpm package manager | ||
|
|
||
| #### Env variables | ||
|
|
||
| - Does not contain the `CACHE_FOLDER` and `FACTORY_DEFAULT_NODE_VERSION` env variables to keep unit tests non environment specific | ||
|
|
||
| [Dockerfile](Dockerfile) | ||
|
|
||
| **Note:** this image uses the `root` user. You might want to switch to non-root user like `node` when running this container for security | ||
|
|
||
| **Note:** Currently, the linux/arm64 build of this image does not contain any browsers except Electron. See https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#browsers for more information. |
5 changes: 5 additions & 0 deletions
5
browsers-internal/releases/node-22/node22.14.0-bullseye-chrome134-ff138-edge/build.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| set e+x | ||
|
|
||
| LOCAL_NAME=cypress/browsers-internal:node22.14.0-bullseye-chrome134-ff138-edge | ||
| echo "Building $LOCAL_NAME" | ||
| docker build -t $LOCAL_NAME . |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't make these case changes in your internal PR.
The case is only used internally.
All the visible names are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier did this automatically - I'll revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins
Let me check for Prettier separately! Thanks for explaining where it came from and for reverting.