Update bump-version.R - replace length test in get_main_branch_config() #775
Conversation
length(table) always returns the number of columns, even for an empty (no rows) table. New test looks for the string "local" in init$level.
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Thank you!!
Can you edit your first GitHub comment in the PR to make it refer to the issue it's closing? See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
R/bump-version.R
Outdated
| @@ -95,17 +95,17 @@ get_main_branch_remote <- function(remote, repo) { | |||
| basename(as.character(remotes$symref[remotes$ref == "HEAD"])) | |||
| } | |||
|
|
|||
| get_main_branch_config <- function(repo) { | |||
| get_main_branch_config <- function(repo) { | |||
There was a problem hiding this comment.
why change the indentation level?
There was a problem hiding this comment.
I'm not sure, it wasn't intentional. Could be a whitespace character artefact or some hiccup with trying to paste code from my IDE into github's online editor. Is there a way to get rid of that without redoing the whole PR from scratch?
edit: I think I did it.
R/bump-version.R
Outdated
|
|
||
| if (length(local)) { | ||
| return(local$value) | ||
| #return local default branch if it exists, otherwise default to global |
There was a problem hiding this comment.
I think the comments can be removed as the code is clear enough: https://blog.r-hub.io/2023/01/26/code-comments-self-explaining-code/
There was a problem hiding this comment.
I think you're right. What would be more helpful is a comment explaining the purpose behind this internal function. It doesn't do much right now but this could be part of allowing for branch names other than "origin".
There was a problem hiding this comment.
thank you! Can you remove the comments then? An alternative to adding a comment about the function would be to improve its name.
There was a problem hiding this comment.
Okay I think I got it right this time. Github is almost as complicated as git itself.
fix indentation at line 98
removing comments
Closes #767
length(table) always returns the number of columns, even for an empty (no rows) table. New test looks for the string "local" in init$level.