Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: pin cylc-flow version #91

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders added this to the 0.3.0 milestone Nov 9, 2021
@oliver-sanders oliver-sanders self-assigned this Nov 9, 2021
@oliver-sanders
Copy link
Member Author

Note, metomi-rose does not presently use the .dev convention.

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to pin the metomi-rose version?

@oliver-sanders
Copy link
Member Author

We can't until release because metomi-rose does not use the .dev convention.

@MetRonnie
Copy link
Member

But why can't we pin to ==2.0b2?

setup.py Outdated Show resolved Hide resolved
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 9, 2021

No reason, but will have to re do this again at release time anyway.

Pinning to metomi-rose versions is not included in the cylc-admin proposal. We might not want to do this to provide a little flexibility for the cylc-rose bridge depending how stable the interface becomes post 8.0.0.

@MetRonnie
Copy link
Member

Oh I see, because it's going to be 2.0b3?

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 9, 2021

Yarp.

Should move projects over to the .dev convention when we get a chance, I think it makes this sort of thing clearer.

@oliver-sanders oliver-sanders merged commit b538879 into cylc:master Nov 9, 2021
@oliver-sanders oliver-sanders deleted the cylc-admin-130 branch November 9, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants