cat-log: list out/err files when available via tailer #6480
+139
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
4 times, most recently
from
320f8f4 to
39e17e5
Compare
* The `--mode=list-dir` option lists log files which are available to view. * This commit includes remote `job.out` and `job.err` files which are available via platform tailer/viewer commands. * Note, these log files are only listed if accessible via *both* a tailer and a viewer in order to prevent ambiguity (these are typically configured together anyway).
oliver-sanders
force-pushed
the
cat-log-list-tailable-files
branch
from
39e17e5 to
f8a248c
Compare
wxtim
reviewed
Jan 29, 2025
There was a problem hiding this comment.
12-delete-kill.t already exists - can we make this number 13?
wxtim
approved these changes
Jan 29, 2025
MetRonnie
requested changes
Feb 5, 2025
| @@ -0,0 +1 @@ | |||
| cat-log: List log files which are availably via a configured tailer/viewer command. | |||
There was a problem hiding this comment.
Suggested change
| cat-log: List log files which are availably via a configured tailer/viewer command. | |
| `cat-log`: List log files which are available via a configured tailer/viewer command. |
MetRonnie
reviewed
Feb 5, 2025
|
|
||
| files.sort() | ||
| print('\n'.join(files)) | ||
| print(err, file=sys.stderr) |
There was a problem hiding this comment.
Currently on 8.4.0 the cat-log -m l command exits non-zero if this subprocess exits non-zero. But it no longer does on this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5802
List log files that are not present on disk but which are available via a tailer.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.