Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cycling_type unit test fixture #4240

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Refactor cycling_type unit test fixture #4240

merged 1 commit into from
Jun 3, 2021

Conversation

MetRonnie
Copy link
Member

This is a small change with no associated Issue. Follow up to #4227

I have tried to make the cycling_type (now set_cycling_type) fixture simpler.

Note the difference between:

  • cycling type: integer or iso8601
  • cycling mode: integer, gregorian, 365day etc.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Does not need tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@MetRonnie MetRonnie added the small label Jun 3, 2021
@MetRonnie MetRonnie added this to the cylc-8.0b2 milestone Jun 3, 2021
@MetRonnie MetRonnie requested a review from hjoliver June 3, 2021 15:32
@MetRonnie MetRonnie self-assigned this Jun 3, 2021
hjoliver
hjoliver approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up!

@hjoliver hjoliver merged commit 57e1e0b into cylc:master Jun 3, 2021
@MetRonnie MetRonnie deleted the cycling-type-fixture branch June 4, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
small
Projects
None yet
Milestone
cylc-8.0b2
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @hjoliver @oliver-sanders