Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM element helpers typings #601

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

wclr
Copy link
Contributor

@wclr wclr commented May 7, 2017

I want to open this PR (will contain multiple commits), for making better typings of DOM helpers based on @TylorS's https://github.com/TylorS/mostly-dom/blob/master/src/types/HtmlProperties.ts

This will also probably require move to TS 2.3.2

@staltz please review initial changes, and say if you ok with the proposal

maybe it would be better to implement in snabbdom?

@staltz
Copy link
Member

staltz commented May 12, 2017

Great initiative @whitecolor ! Keep on going with this please :)

Eventually it would be good to put this in snabbdom, but Cycle.js has a unique hyperscript helper, so it makes sense to do what you're doing now.

I'd also recommend writing some tests (they are in TypeScript nowadays) before implementing everything. It doesn't need to be full TDD, but just a few tests so we know what is the goal API that we want to get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants