Support ESLint v7 #272
Support ESLint v7 #272
Conversation
package.json
Outdated
| "eslint": "^6.4.0", | ||
| "typescript": "^3.3.3333" | ||
| "eslint": "^7.0.0", | ||
| "typescript": ">=3.3.1 <3.10.0" |
There was a problem hiding this comment.
This versions referenced to typescript-eslint#supported-typescript-version
There was a problem hiding this comment.
@toshi-toma Could you suggest this again because of stale?
ghost
requested a review
from
| assert.deepStrictEqual(result, { | ||
| "error.js": { | ||
| errors: [ | ||
| "no-var", | ||
| "no-unused-vars", | ||
| "no-var", | ||
| "no-redeclare", | ||
| "getter-return", |
There was a problem hiding this comment.
The order of the errors is not the same between Node v10 and v12, so I temporarily disable the errors.
| assert.deepStrictEqual(result, { | ||
| "error.js": { | ||
| errors: ["no-unused-vars", "no-redeclare"] |
There was a problem hiding this comment.
The order of the errors is not the same between Node v10 and v12, so I temporarily disable the errors.
|
|
package.json
Outdated
| "eslint-plugin-flowtype": "^4.7.0", | ||
| "eslint-plugin-import": "^2.20.2", | ||
| "eslint-plugin-flowtype": "^5.1.3", | ||
| "eslint-plugin-import": "^2.21.2", | ||
| "eslint-plugin-jsx-a11y": "6.2.3", |
There was a problem hiding this comment.
It's going to be released in a few minutes.
Do you want to fix this separately?
jsx-eslint/eslint-plugin-jsx-a11y#684 (comment)
There was a problem hiding this comment.
@toshi-toma Thanks. I've updated it to the latest version.
BREAKING CHANGE: Support minimum ESLint version is v7.
BREAKING CHANGE: eslint-plugin-react-hooks reports new errors
BREAKING CHANGE: enable new rules in typescript-eslint/recommended
ESLint v7 has been released so we'd like to support ESLint v7.
https://eslint.org/blog/2020/05/eslint-v7.0.0-released
THIS PR IS A BREAKING CHANGE because this drops to support ESLint v6.
Breaking Changes
@typescript-eslint/recommended@typescript-eslint/no-extra-non-null-assertion@typescript-eslint/no-extra-semi@typescript-eslint/no-non-null-asserted-optional-chain@typescript-eslint/prefer-as-constTasks
@typescript-eslint/eslint-pluginESLint v7 typescript-eslint/typescript-eslint#1550@typescript-eslint/parserESLint v7 typescript-eslint/typescript-eslint#1550eslint-plugin-flowtypeSupport ESLint 7.x gajus/eslint-plugin-flowtype#446eslint-plugin-importimport-js/eslint-plugin-import@6a110ddeslint-plugin-jsx-a11yhttps://github.com/evcohen/eslint-plugin-jsx-a11y/issues/683eslint-plugin-nodeSupport ESLint 7.x mysticatea/eslint-plugin-node#223eslint-plugin-prettierAdd tests for running ESLint 7 prettier/eslint-plugin-prettier#291eslint-plugin-react[New] support eslint v7 jsx-eslint/eslint-plugin-react#2635eslint-plugin-react-hooksfeat(eslint-plugin-react-hooks): Support ESLint 7.x facebook/react#18878