ci: parallelize tests more aggressively #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
ci-parallelize
branch
8 times, most recently
from
1b1b04b to
ea1d154
Compare
ushitora-anqou
force-pushed
the
ci-parallelize
branch
5 times, most recently
from
f77bdd3 to
5b702b0
Compare
This commit separates the tests in the
test/e2e/multik8s/replication/suite_test.go into 3 different files, i.e.,
full_backup_test.go, incremental_backup_test.go, and misc_test.go. The
tests in each file has each different label ("full-backup",
"incremental-backup", or "misc"), and these labels are used to
parallelize the tests in the CI.
There should be no functional changes in this commit.
Signed-off-by: Ryotaro Banno <[email protected]>
…ckage The replicationfailure package was made to parallelize the e2e tests. However, we can use labels for this purpose. This commit moves the tests in the replicationfailure package to replication package. Instead, it attaches "backup-failure" label to the tests so that they can run in parallel. There should be no functional changes in this commit. Signed-off-by: Ryotaro Banno <[email protected]>
The changetoprimary package was made to parallelize the e2e tests. However, we can use labels for this purpose. This commit moves the tests in the changetoprimary package to replication package. Instead, it attaches "change-to-primary" label to the tests so that they can run in parallel. There should be no functional changes in this commit. Signed-off-by: Ryotaro Banno <[email protected]>
…kage The changetosecondary package was made to parallelize the e2e tests. However, we can use labels for this purpose. This commit moves the tests in the changetosecondary package to replication package. Instead, it attaches "change-to-secondary" label to the tests so that they can run in parallel. There should be no functional changes in this commit. Signed-off-by: Ryotaro Banno <[email protected]>
The changetostandalone package was made to parallelize the e2e tests. However, we can use labels for this purpose. This commit moves the tests in the changetostandalone package to replication package. Instead, it attaches "change-to-standalone" label to the tests so that they can run in parallel. There should be no functional changes in this commit. Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
ci-parallelize
branch
from
5b702b0 to
74071f6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the test suite organization for multi‑k8s replication tests by parallelizing the execution through Ginkgo labels rather than Go package grouping, with no intended functional changes. Key changes include:
- Removal of the replicationfailure suite_test.go file.
- Addition of multiple new test files under the replication directory for full, incremental, backup-failure, and role-change scenarios.
- Updates to the CI workflow YAML to replace ginkgo-flags with label-filter configuration.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/e2e/multik8s/replicationfailure/suite_test.go | File removed as part of test reorganization. |
| test/e2e/multik8s/replication/*.go | New/updated test files covering replication, backup scenarios, and role changes. |
| .github/workflows/e2e-multiple-k8s-clusters.yaml | Updated matrix configuration to use label-filter instead of ginkgo-flags for selecting tests. |
Files not reviewed (1)
- test/e2e/Makefile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a kaizen and should have no functional changes.
This PR parallelizes the e2e multik8s tests by using Ginkgo labels instead of Go packages. See each commit message for the details.