feat(desktop-app): tauri setup #1160

dr-leevsey · 2024-05-13T08:45:47Z

yarn tauri dev to start development mode
yarn tauri build produces APP bundle and DMG under src-tauri/target/release folder

netlify · 2024-05-13T08:46:02Z

✅ Deploy Preview for cyb-xp ready!

Name	Link
🔨 Latest commit	`3c0eb6e`
🔍 Latest deploy log	https://app.netlify.com/sites/cyb-xp/deploys/67138561c7794d0008225d63
😎 Deploy Preview	https://deploy-preview-1160--cyb-xp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-05-13T08:46:03Z

✅ Deploy Preview for rebyc ready!

Name	Link
🔨 Latest commit	`3c0eb6e`
🔍 Latest deploy log	https://app.netlify.com/sites/rebyc/deploys/67138561d26e5400089858c7
😎 Deploy Preview	https://deploy-preview-1160--rebyc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

… feat/tauri-app

…ess/cyb-ts into feat/tauri-app

…wnload and signing flow fixes

…eat/tauri-app

… feat/tauri-app

happylolonly · 2024-10-18T08:48:30Z

src/pages/Settings/Layout/SettingsMenu/SettingsMenu.tsx

@@ -24,6 +24,13 @@ const links: Array<MenuItem[]> = [
      icon: '🗝',
    },
  ],
+  [
+    {


as I undestand this shoudn't be if no signer flag

it must be available if there's no keplr extension, it's not desktop only

happylolonly · 2024-10-18T08:49:06Z

src/pages/Sign/Sign.style.ts

@@ -0,0 +1,8 @@
+import { CSSProperties } from 'react';
+
+export const heading: CSSProperties = { marginBottom: '25px' };


happylolonly · 2024-10-18T08:50:03Z

src/pages/Sign/Sign.tsx

+
+export default function Sign() {
+  const { signingClient } = useSigningClient();
+  const [params] = useSearchParams();


seems types can be added

what kind of types?

happylolonly · 2024-10-18T08:51:19Z

src/pages/Sign/Sign.tsx

+        <div>
+          <h2 style={styles.heading}>Confirm transaction</h2>
+          {messages && messages.length > 0 && (
+            <div style={{ paddingTop: '23px', paddingBottom: '46px' }}>


happylolonly · 2024-10-18T08:52:04Z

src/pages/robot/_refactor/account/actionBar.tsx

@@ -1,30 +1,31 @@
-import React, { Component } from 'react';
+/* eslint-disable */


this not good, for what?

I think it was already there, I just moved it to top of file I guess
I can remove it

happylolonly · 2024-10-18T08:52:23Z

src/pages/robot/_refactor/account/actionBar.tsx

@@ -300,7 +301,11 @@ class ActionBarContainer extends Component<Props> {
    const isOwner = defaultAccount && defaultAccount.bech32 === addressSend;

    if (stage === STAGE_INIT) {
-      const followBtn = <Button onClick={this.onClickSend}>Follow</Button>;
+      const followBtn = (
+        <Button key={'action-bar-button-follow'} onClick={this.onClickSend}>


happylolonly · 2024-10-18T08:54:09Z

src/pages/teleport/hooks/useSetupIbcClient.ts

@@ -20,29 +29,46 @@ function useSetupIbcClient(denom, network) {

      let client = null;
      if (network && network !== CHAIN_ID) {
+        const { rpc, prefix, sourceChainId, chainId } = networks[network];


@dimakorzhovnik please review

happylolonly · 2024-10-18T08:54:52Z

src/redux/features/action-bar.ts

@@ -0,0 +1,76 @@
+import { PayloadAction, createSlice } from '@reduxjs/toolkit';


this file should be removed?

happylolonly · 2024-10-18T08:58:43Z

src/redux/features/signer.ts

@@ -0,0 +1,70 @@
+import { StdFee } from '@cosmjs/launchpad';


as I see this file almost not being used, it is needed? lets discuss

confirmation is still in use

happylolonly · 2024-10-18T09:00:58Z

src/services/CozoDb/cozoDb.ts

-      DB_STORE_NAME,
-      onIndexedDbWrite
-    );
+    if (!process.env.IS_TAURI) {


maybe this flag better rename to IS_DESKTOP?

happylolonly · 2024-10-18T09:04:16Z

src/services/backend/workers/background/service.ts

@@ -1,3 +1,4 @@
+/* eslint-disable import/prefer-default-export */


better use this with next line not global

my counter-offer is to disable this rule completely, it's more headache then benefit

happylolonly · 2024-10-18T09:08:23Z

src/services/signer/signer-modal-handler.ts

+  memo?: string | undefined;
+}
+
+export class SignerModalHandler {


maybe it can be context better? to use OOP less with react

if it would be context it would be also redux (what's the difference to be honest?!)
it's done that way to make it possible to use it outside the react scope (literally in CybSignerClient)

happylolonly · 2024-10-18T09:10:13Z

src/types/index.d.ts

+declare global {
+  interface Window {
+    store: Store;
+    clipboardData?: DataTransfer;


clipboardData needed to specify?

check it's usage, it will be clear

happylolonly · 2024-10-18T09:10:28Z

src/types/index.d.ts

 export type Option<T> = T | undefined;
 export type Nullable<T> = T | null | undefined;
 export type ArrayElement<ArrayType extends readonly unknown[]> =
  ArrayType extends readonly (infer ElementType)[] ? ElementType : never;
+declare global {
+  interface Window {
+    store: Store;


happylolonly · 2024-10-18T09:12:02Z

src/utils/get-txs-with-retry.ts

+import { requestWithRetry } from './request-with-retry';
+
+/* eslint-disable import/prefer-default-export */
+export const getTxsWithRetry = async (txs: string) => {


not being used

yeah, right now it's not
but it look much better alternative to this pattern

happylolonly · 2024-10-18T09:12:41Z

src/utils/request-with-retry.ts

+/* eslint-disable import/prefer-default-export */
+import axios, { AxiosError, AxiosRequestConfig, AxiosResponse } from 'axios';
+
+export const requestWithRetry = async (


happylolonly · 2024-10-18T09:13:40Z

src/utils/shareNavigation.ts

+
+let navigate: NavigateFunction;
+
+export const setNavigate = (nav: NavigateFunction) => {


happylolonly · 2024-10-18T09:13:54Z

src/utils/utils.ts

@@ -442,3 +442,5 @@ export {
  getNowUtcTime,
  accountsKeplr,
 };
+
+export const getMnemonic = () => localStorage.getItem('cyb:mnemonic');


localStorageKeys

happylolonly · 2024-10-18T09:14:55Z

webpack.config.prod.tauri.js

+const CompressionWebpackPlugin = require('compression-webpack-plugin');
+const commonConfig = require('./webpack.config.common');
+
+module.exports = merge(commonConfig, {


can production config be reused/merged?

I agree that's possible
matter of time as lots of other things

happylolonly · 2024-10-18T09:16:40Z

src/components/modal/Modal.tsx

+    [style]
+  );
+
+  return isOpen ? (


better (!isOpen) {
return null
}

I agree on early return

happylolonly

need some small fixes, but core is ok

… feat/tauri-app

feat(tauri-app): initial tauri setup

1c62021

Andrejs and others added 14 commits May 23, 2024 09:29

feat(tauri-app): working offline signer | modal in progress

734c6cf

Merge branch 'master' of https://github.com/cybercongress/cyb-ts into…

0b58621

… feat/tauri-app

feat(tauri-app): working mnemonics modal

02df9e7

Create build_tauri_app.yml

3c9419b

fix(tauri-build): removed empty step

966df5d

chore(tauri-app): trigger manually

56dd77f

feat(tauri-app): connect wallet modal updates and cleanup

cf53df6

feat(tauri-app): signer modal window

5c6c6fa

feat(tauri-app): cancel button and basic validation

7021878

fix(tauri-app): webkit does not support persistent storage

2e01ed7

feat(offline-signer): signer modal used to sign transaction

be48fa2

Merge branch 'master' of https://github.com/cybercongress/cyb-ts into…

e99509a

… feat/tauri-app

feat(tauri-app): use workers in app | modals refactoring

2080067

Merge branch 'chore/build-tauri-app' of https://github.com/cybercongr…

e7936b1

…ess/cyb-ts into feat/tauri-app

dr-leevsey mentioned this pull request Jun 30, 2024

Create build_tauri_app.yml #1176

Closed

happylolonly assigned dr-leevsey Jun 30, 2024

happylolonly added feature Atomic function which can be described epic Set of features which add significant value labels Jun 30, 2024

Andrejs added 2 commits July 3, 2024 14:59

feat(tauri-app): switched signer from modal to /sign page

05168c6

feat(tauri-app): changed action bar state management moved to redux

0de0392

happylolonly marked this pull request as draft July 10, 2024 05:25

Andrejs and others added 6 commits July 10, 2024 20:44

feat(tauri-app): fetch and run kubo on app start

fa3ce94

feat(tarui-app): detect platform when downloading ipfs

1e61c49

feat(tauri-app): wip

5c428fb

feat(tauri-app): action bar refactoring, ipfs initialization after do…

0fc73ab

…wnload and signing flow fixes

Merge branch master of https://github.com/cybercongress/cyb-ts into f…

ca86120

…eat/tauri-app

Merge branch 'master' of https://github.com/cybercongress/cyb-ts into…

619a6fa

… feat/tauri-app

happylolonly reviewed Oct 18, 2024

View reviewed changes

src/utils/shareNavigation.ts

let navigate: NavigateFunction;

export const setNavigate = (nav: NavigateFunction) => {

Copy link

Member

happylolonly Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not using

happylolonly reviewed Oct 18, 2024

View reviewed changes

happylolonly requested changes Oct 18, 2024

View reviewed changes

happylolonly requested review from dasein108, dimakorzhovnik and El-NIVVO October 18, 2024 09:18

happylolonly marked this pull request as ready for review October 18, 2024 09:54

happylolonly changed the title ~~feat(desktop-app): initial tauri setup~~ feat(desktop-app): tauri setup Oct 18, 2024

dasein108 approved these changes Oct 18, 2024

View reviewed changes

Andrejs added 3 commits October 19, 2024 12:14

Merge branch 'master' of https://github.com/cybercongress/cyb-ts into…

7eeb994

… feat/tauri-app

fix(tauri-app): version bump and review comments

4c50514

fix(tauri-app): review comments

3c0eb6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(desktop-app): tauri setup #1160

feat(desktop-app): tauri setup #1160

dr-leevsey commented May 13, 2024

netlify bot commented May 13, 2024 •

edited

Loading

netlify bot commented May 13, 2024 •

edited

Loading

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

happylolonly Oct 18, 2024

dr-leevsey Oct 19, 2024

happylolonly Oct 18, 2024 •

edited

Loading

dr-leevsey Oct 19, 2024

happylolonly left a comment

		@@ -0,0 +1,8 @@
		import { CSSProperties } from 'react';

		export const heading: CSSProperties = { marginBottom: '25px' };

		@@ -1,30 +1,31 @@
		import React, { Component } from 'react';
		/* eslint-disable */

		@@ -0,0 +1,76 @@
		import { PayloadAction, createSlice } from '@reduxjs/toolkit';

		@@ -1,3 +1,4 @@
		/* eslint-disable import/prefer-default-export */


		let navigate: NavigateFunction;

		export const setNavigate = (nav: NavigateFunction) => {

feat(desktop-app): tauri setup #1160

Are you sure you want to change the base?

feat(desktop-app): tauri setup #1160

Conversation

dr-leevsey commented May 13, 2024

netlify bot commented May 13, 2024 • edited Loading

✅ Deploy Preview for cyb-xp ready!

netlify bot commented May 13, 2024 • edited Loading

✅ Deploy Preview for rebyc ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

happylolonly Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

happylolonly left a comment

Choose a reason for hiding this comment

netlify bot commented May 13, 2024 •

edited

Loading

netlify bot commented May 13, 2024 •

edited

Loading

happylolonly Oct 18, 2024 •

edited

Loading