Feat/add new leverage for new mint markets #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedorovdg
force-pushed
the
feat/add-new-leverage-for-new-mintMarkets
branch
2 times, most recently
from
fed1b6a to
f3ac41b
Compare
DanielSchiavini
requested changes
Apr 29, 2025
| return await this._deprecatedLeverageCreateLoan(collateral, debt, range, slippage, false) as string; | ||
| } | ||
|
|
||
| // ---------------- LEVERAGE CREATE LOAN ---------------- |
There was a problem hiding this comment.
We cannot keep on adding code to the same file and mix market types
We need proper way of separating the different markets in separate files
There was a problem hiding this comment.
I cannot review this because I don't know what's new and what's copied
src/interfaces.ts
Outdated
| @@ -33,6 +33,8 @@ export interface ILlamma { | |||
| default_bands: number, | |||
| A: number, | |||
| monetary_policy_abi: any | |||
| is_new_market?: boolean | |||
There was a problem hiding this comment.
Can we use a proper name for this flag, for example using the feature name like isDeleverageSupported?
This is not scalable. Next update we cannot use this anymore
fedorovdg
force-pushed
the
feat/add-new-leverage-for-new-mintMarkets
branch
from
9bd92db to
d65bd14
Compare
feat: add new leverage for new mintMarkets
fedorovdg
force-pushed
the
feat/add-new-leverage-for-new-mintMarkets
branch
from
c419013 to
f0211a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.