-
-
Notifications
You must be signed in to change notification settings - Fork 88
Add sandbox setup cmd for VSCodium #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
db3ab51
feat: codium sandbox setup cmd (wip)
rinOfTheStars 9edd9ad
hacky workaround to OpenVSX Marketplace stuff
rinOfTheStars 963c0e4
Update CONTRIBUTING docs and change format to mdx
rinOfTheStars 5d67e7f
Merge branch 'main' into main
rinOfTheStars c7b00dd
Setup script consolidation, update CONTRIBUTING.mdx
rinOfTheStars 18b145a
Fix lack of tabs on a code/codium command mention
rinOfTheStars 498aca0
Merge branch 'main' into main
rinOfTheStars 3caf6ef
Merge branch 'main' into main
rinOfTheStars 1593ee4
Update .gitignore
rinOfTheStars 7c80580
Update CONTRIBUTING.mdx
rinOfTheStars 148ff04
Update CONTRIBUTING.mdx
rinOfTheStars 3b58880
Pass cli tool name as param, update CONTRIBUTING.mdx
rinOfTheStars 687bd4c
Merge branch 'main' of https://github.com/rinOfTheStars/cursorless
rinOfTheStars 85a3c3f
Merge branch 'cursorless-dev:main' into main
rinOfTheStars 75605c0
Merge branch 'main' into main
rinOfTheStars 4692560
Update packages/cursorless-org-docs/src/docs/contributing/CONTRIBUTIN…
rinOfTheStars 811221e
Update initLaunchSandbox.ts
rinOfTheStars 7d74c0c
ran prettier
AndreasArvidsson 36ff867
Clean up sandbox script
AndreasArvidsson b4803f4
Merge branch 'main' into main
AndreasArvidsson f679748
Fix build problem with quotes
AndreasArvidsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed if it should go in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should compile fail locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I knew 😓 but as I noted in the talon slack, it fails locally on my machine despite seemingly having no reason to. Still trying to track down what's wrong with my setup (or if its a regression/bug that only occurs for new contributors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have a discord session about that. Not being able to compile locally is not a good developer experience.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is a known issue on the
@types
maintainers' end that fell through the cracks and never got fixed: DefinitelyTyped/DefinitelyTyped#43912Adding
"skipLibCheck": true
to the base ts config (tsconfig.base.json
) seems to fix this issue without causing any itself (running all tests seems to work fine); no clue why the bug happens on some systems but not others, however, or if there are potential major caveats to this fix. If there's some way to detect when a build fails due to the conflict between@types/mocha
and@types/jest
and only then pass this config argument, that would probably be better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I have a link to the discord, then? Idk if I want to do voice call stuff but seeing if other people can replicate this (bc it is extremely odd it only happens on my machine, and yet occurs regardless of install location) is probably best done there, yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly.
https://discord.gg/zGdVz2pD
That sounds like it might be a path or other environment variable interfering?
Anyhow I don't think we should have texts in the documentation expecting people not to be able to compile cursorless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair enough honestly. I wish I had any clue as to what exactly is preventing
pnpm compile
from working, but honestly I'm entirely clueless at this point. My only guess is it has something to do with homebrew itself, or with the filesystem being used? I'm probably going to do a disk wipe + reinstall sometime soon anyway (I've got backups through a Time Machine external disk, so I'll manually restore stuff piecemeal when I need it) so if that doesn't fix this issue when running everything from as fresh of an install as possible, then I guess that'd could as reproduction?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really strange. Let's do this. Can you run the below commands and give me the full log? You can do it on slack if you don't want to post it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gist.github.com/rinOfTheStars/522c9b95f28cc3d4b0b9d9b98eacfb95
Unless there's something going on with one of the
node
/npm
/pnpm
versions being used, nothing seems out of the ordinary until thepnpm compile
failure at the end.