Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#459 - tests remove deprecated methods #460

Conversation

ricardogarfe
Copy link
Contributor

@ricardogarfe ricardogarfe commented Feb 18, 2022

🤔 What's changed?

Remove use of deprecated methods

⚡️ What's your motivation?

Have some examples up to date to continue using the framework and improve examples

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt (improvement to code design or tooling without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@vearutop
Copy link
Member

Looks good, could you also update change log?

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #460 (30a9d41) into main (c95871f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files          27       27           
  Lines        2183     2183           
=======================================
  Hits         1781     1781           
  Misses        309      309           
  Partials       93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95871f...30a9d41. Read the comment docs.

@ricardogarfe
Copy link
Contributor Author

Looks good, could you also update change log?

Done 👍🏽 Thanks!

@vearutop vearutop merged commit 5efecba into cucumber:main Feb 18, 2022
@aslakhellesoy
Copy link
Contributor

Hi @ricardogarfe,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mattwynne
Copy link
Member

Nice quick turnaround folks!

@mattwynne
Copy link
Member

@ricardogarfe thanks for your contribution! We are actively seeking maintainers for this project, so if you're interested in spending any more time on that we'd love to help.

I'm available for live pairing ⚡ you can book a slot with me here.

@ricardogarfe
Copy link
Contributor Author

Thanks to you, and all maintainers of the software ;) and the support to the community
I've only made a little contribution

@mattwynne
Copy link
Member

Every bit helps @ricardogarfe ❤️

@ricardogarfe ricardogarfe deleted the test-459-update-deprecated-methods-on-examples branch February 28, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants