Skip to content

fix(questdb-driver): Fix invalid QuestDB timestamp floor year unit #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 13, 2025

This PR supersedes the original one #7474 by @peterklingelhofer. Fixes tests and updates snapshots.

Closes #7474.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review June 13, 2025 16:52
@KSDaemon KSDaemon requested review from a team as code owners June 13, 2025 16:52
@peterklingelhofer
Copy link
Contributor

Thank you for taking this the final leg @KSDaemon

@KSDaemon KSDaemon merged commit 33012b1 into master Jun 17, 2025
44 checks passed
@KSDaemon KSDaemon deleted the peterklingelhofer-bugfix/invalid-timestamp-floor-year-unit branch June 17, 2025 08:49
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…ube-js#9678)

* bugfix: Invalid QuestDB timestamp floor year unit

* feat: Unit GraphQL tests for year aggregation query

* fix tests

---------

Co-authored-by: Peter Klingelhofer <[email protected]>
Co-authored-by: Peter Klingelhofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants