Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the length check for pre-aggregation table name #9061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Remove the length check for pre-aggregation table name #9061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/cubejs-schema-compiler/src/adapter/MysqlQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,6 @@ export class MysqlQuery extends BaseQuery {
return `IF(${sql}, 1, 0)`;
}

public preAggregationTableName(cube, preAggregationName, skipSchema) {
const name = super.preAggregationTableName(cube, preAggregationName, skipSchema);
if (name.length > 64) {
throw new UserError(`MySQL can not work with table names that longer than 64 symbols. Consider using the 'sqlAlias' attribute in your cube and in your pre-aggregation definition for ${name}.`);
}
return name;
}

public sqlTemplates() {
const templates = super.sqlTemplates();
templates.quotes.identifiers = '`';
Expand Down
8 changes: 0 additions & 8 deletions packages/cubejs-schema-compiler/src/adapter/OracleQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,4 @@ export class OracleQuery extends BaseQuery {
// eslint-disable-next-line quotes
return `((cast (systimestamp at time zone 'UTC' as date) - date '1970-01-01') * 86400)`;
}

public preAggregationTableName(cube, preAggregationName, skipSchema) {
const name = super.preAggregationTableName(cube, preAggregationName, skipSchema);
if (name.length > 128) {
throw new UserError(`Oracle can not work with table names that longer than 64 symbols. Consider using the 'sqlAlias' attribute in your cube and in your pre-aggregation definition for ${name}.`);
}
return name;
}
}
Loading