feat(drivers): introduce Apache Pinot #8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
Bartducrot
approved these changes
Sep 20, 2024
jronsse
force-pushed
the
feat/pinot-rest-driver
branch
from
eed65b1 to
13008ef
Compare
paveltiunov
reviewed
Sep 28, 2024
There was a problem hiding this comment.
@jronsse Thanks for contributing this one! This is really huge! Overall looks great! We need to do only minor polishing I mentioned in comments.
|
|
||
| ### Installation | ||
|
|
||
| `npm i @inthememory/pinot-driver` |
There was a problem hiding this comment.
We don't need those instructions as it'd be packed as a part of distribution.
| } | ||
|
|
||
| public hllInit(sql: string) { | ||
| return this.countDistinctApprox(sql); // todo: ensure the correct way to do so in pinot |
There was a problem hiding this comment.
This doesn't seem correct so let's remove it for now to avoid weird error messages
| } | ||
|
|
||
| public hllMerge(sql: string) { | ||
| return this.countDistinctApprox(sql); // todo: ensure the correct way to do so in pinot |
|
|
||
| ## SSL | ||
|
|
||
| Cube does not require any additional configuration to enable SSL as Elasticsearch connections are made over HTTPS. |
There was a problem hiding this comment.
I guess it should refer to Pinot instead of Elasticsearch?
| `npm i @inthememory/pinot-driver` | ||
|
|
||
| ### Usage | ||
| #### For Docker |
|
|
||
| [Learn more](https://github.com/cube-js/cube.js#getting-started) | ||
|
|
||
| ### Project Status |
| /** | ||
| * @copyright Cube Dev, Inc. | ||
| * @license Apache-2.0 | ||
| * @fileoverview The `PrestoDriver` and related types declaration. |
There was a problem hiding this comment.
I guess it's PinotDriver instead of PrestoDriver
KSDaemon
changed the title
ptiurin
pushed a commit
to firebolt-db/cube
that referenced
this pull request
Nov 27, 2024
* feat(driver): introduce Apache Pinot * feat(driver): add Pinot documentation * chore: publish under inthememory scope * chore: clear changelog * chore: rebase master --------- Co-authored-by: Konstantin Burkalev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#8579
Description of Changes Made
The driver uses Pinot's Broker Rest API to submit queries. Multi-stage engine is enabled by default for every query since it offers better SQL support.
Published to npm
npm i @inthememory/pinot-driver