Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1165 Coinbase API Change #1168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ngqinzhe
Copy link

Coinbase API removed base_min_size and replaced it with min_market_funds.

Issue Link:
#1165

Change docs:
https://docs.cloud.coinbase.com/exchange/docs/changelog#2022-jun-02

@nonkreon
Copy link
Contributor

nonkreon commented Sep 7, 2022

Hi @ngqinzhe
Thanks for the MR, I've also been trying to test the same but can't get K to compile from source on my machine anymore for some reason.
EDIT: because I hit #1166 too, didn't notice other people were experiencing the same too. how did you get over it, can you share the fix for that too?
There's another update coming at the end of this month, the API addresses will change, if you e-mail clientservices at coinbase dot com you can start using the new API to test. Can you throw that in too so when we get @ctubio attention he can merge both? Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants