Ignore timestamp updates in update_invoice_line_items_with_invoicing_… #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made ctsit/redcapcustodian#88 in the hope that someday we will do this the right way. |
|
I need this code badly as I continue to run this ETL. I reviewed my work and it still works. I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore timestamp updates in
update_invoice_line_items_with_invoicing_details.R. As Sandar is sending us large, multi-month AR reports, we need to ignore things we already know, but the dataset diff function in redcapcustodian sees the novel timestamps in theupdatedcolumn as a difference. we need to ignoreupdatedin the diff, yet still write it anytime we make updates.This is not the most elegant solution, but it gets the job done for now. Yes, I ran this against production data and it worked. I'll add an issue in redcap custodian to describe the need to ignore a column in the diff and yet include it in the diff.