Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitorPosition passthrough #82

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

bradennapier
Copy link

Added ability to specify monitorPosition as well.

@ctrlplusb
Copy link
Owner

Hey @bradennapier

Thanks for taking this on. I am happy with the monitorPosition changes but I am wondering about your motivation for the sizePassThrough prop?

@ctrlplusb
Copy link
Owner

And... I have just read your first PR notes. Hmmm interesting case. I wonder if this should be considered on react-sizeme.

I would like to take some time to consider this separately. Ideally I think if you are using react-component-queries you shouldn't have the size get passed down to the WrappedComponent anyways. It should only be handled by the responsive functions.

Do you mind removing the concept of size pass through from this PR so we can merge the rest? We can continue the discussion then on the other PR you opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants