Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed linting issue causing build failure #111

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fixed linting issue causing build failure #111

merged 2 commits into from
Nov 6, 2024

Conversation

simon-wg
Copy link
Contributor

@simon-wg simon-wg commented Nov 6, 2024

See title

@simon-wg simon-wg changed the title replaced map_err with inspect_err since we do not modify the error Fixed linting issue causing build failure Nov 6, 2024
ViktorYeet
ViktorYeet approved these changes Nov 6, 2024
View reviewed changes
Copy link

@ViktorYeet ViktorYeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what could go wrong

@simon-wg simon-wg merged commit c5bc524 into main Nov 6, 2024
18 checks passed
@simon-wg simon-wg deleted the fix/linting-map_err-to-inspect_err branch November 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorYeet ViktorYeet ViktorYeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-wg @ViktorYeet