This repository was archived by the owner on Dec 12, 2024. It is now read-only.
Avoid calling EnableReplication and markVolumeAsSecondary repeatedly #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
force-pushed
the
refractor-calls
branch
2 times, most recently
from
5c1f953 to
e04f0e0
Compare
call EnableVolumeReplication only if the request is to mark the image as primary Signed-off-by: Madhu Rajanna <[email protected]>
Demote the volume only once if the instance state is primary. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
refractor-calls
branch
from
e04f0e0 to
8caf81a
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following 2 changes
status.stateis not set to secondary.Signed-off-by: Madhu Rajanna [email protected]