Allow Switch has outline on focus #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now Switch does not have an outline on focus. It's not good from points of accessibility and keyboard navigation. I add `_focusVisible` styles copied from `button` recipe and it looks good
|
@Seigiard is attempting to deploy a commit to the Personal Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Switch component lacks an outline when focused, which poses challenges for accessibility and keyboard navigation.
To address this, I've added
_focusVisiblestyles derived from the button component. This improvement enhances visibility and accessibility, ensuring the Switch component is easier to navigate and use.