Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 feat filtering for ride table #39

Merged
merged 14 commits into from
Mar 12, 2025

Conversation

wilsonylai
Copy link

@wilsonylai wilsonylai commented Mar 2, 2025

Summary:

  • Implemented filtering for every column except Notes to Driver and Notes (Date Reserved) columns for Rides table
  • Implemented very basic rspec tests
  • Renamed previous filtering page to: today (better name for it since it reflects the rides for the current day)

We should merge this to main for now and do the transfering over to the Datatables gem in issue #47

clu723 and others added 3 commits February 27, 2025 10:42
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.84%. Comparing base (e68274c) to head (59b1b25).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
app/controllers/rides_controller.rb 90.90% 1 Missing ⚠️
app/models/ride.rb 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   87.70%   87.84%   +0.14%     
==========================================
  Files          31       31              
  Lines         374      395      +21     
==========================================
+ Hits          328      347      +19     
- Misses         46       48       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@DanielQLTan DanielQLTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks awesome, need to add tests before merging.

Copy link

@ZhixiaLin ZhixiaLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, more test coverage would be better!

@DanielQLTan
Copy link

btw this now has conflicts with main. I was gonna revert the changes there but I feel like resolving these here is better.

@clu723 clu723 removed their request for review March 8, 2025 18:33
@clu723 clu723 self-assigned this Mar 8, 2025
@clu723 clu723 changed the title 23 feat filtersort passenger and ride information 23 feat filtering for ride table Mar 11, 2025
Copy link

@DanielQLTan DanielQLTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for current implementation.

Copy link

@AthenaJenkins AthenaJenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thank you for addressing the issues we discussed. Ideally we would be using FactoryBot for our testing (as opposed to just fully building test models on our own) but I think setting all that up can be a separate issue

@DanielQLTan DanielQLTan merged commit 56fc6f3 into main Mar 12, 2025
7 checks passed
@DanielQLTan DanielQLTan deleted the 23-feat-filtersort-passenger-and-ride-information branch March 12, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request points: 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Filter/Sort Passenger and Ride Information
6 participants