-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement getCode cheatcode #593
base: master
Are you sure you want to change the base?
Conversation
This is still WIP
On a separate note, |
Hey @0xZRA sorry for the delay - will provide feedback today :) |
|
||
require(deployedHash == referenceHash, "Retrieved bytecode doesn't match reference"); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to add a newline here
@0xZRA before reviewing the PR i want to make sure we satisfy the issue. It is possible that the creator of the issue does in fact want the versioning support as well. If they do then you may need to add support for that as well. |
@anishnaik For sure, makes sense to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major feedback outside of the optimization I mentioned :) Appreciate all the work!
@@ -94,6 +95,10 @@ type TestChain struct { | |||
// stateFactory used to construct state databases from db/root. Abstracts away the backing RPC when running in | |||
// fork mode. | |||
stateFactory state.MedusaStateFactory | |||
|
|||
ContractBytecodes map[string][]byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer having a pointer reference to the CompiledContract
s over the bytecodes since it is more memory efficient and we can access the same information.
I should be able to wrap this up within next few days |
No description provided.