Feature: Windows debug launcher #2666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
approved these changes
Feb 6, 2023
| -Dcryptomator.integrationsWin.autoStartShellLinkName="$AppName" \ | ||
| -Dcryptomator.integrationsWin.keychainPaths="~/AppData/Roaming/$AppName/keychain.json" \ | ||
| -Dcryptomator.showTrayIcon=true \ | ||
| -Dcryptomator.buildNumber="msi-${REVISION_NUM}" |
There was a problem hiding this comment.
We might even add -dbg here, what do you think?
There was a problem hiding this comment.
You mean a new jvm property (e.g., cryptomator.dbg) which is read by the application?
There was a problem hiding this comment.
No just the build number, so we know whether people started the debug launcher
There was a problem hiding this comment.
Ah, got it! Yes, that's a good idea.
* substitute all java-options * use correct properties path * fix read-only attribute of debug launcher
|
Currently the jpackage build fails with: Noteable is the first/second line. Seems like an internal JDK bug. I'll try to reproduce it with a minimal example. Interestingly, the debug executable is still build, only certain file properties cannot be altered. (Maybe a read-only problem?) |
|
Update: A ticket is created in the jdk issue tracker for it, see https://bugs.openjdk.org/browse/JDK-8303325. |
infeo
added
state:blocked
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #2661.
It was evaluated, if we could simply add
--win-console(see jpackage doc) to our main application and avoid an additional launcher. But doing so would result in bad user experience: Everytime Cryptomator is started, also acmdTerminal is started.Hence, to gather extended debug output on windows, we need the launcher. But we decided use it as general debug launcher (in contrast to former PR). This increases maintenance, but we'll be able to analyze with the help of users certain windows-related problems in more detail.