Skip to content

Vignette update #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Vignette update #30

merged 4 commits into from
Aug 22, 2024

Conversation

RLumSK
Copy link
Collaborator

@RLumSK RLumSK commented Aug 22, 2024

I took the liberty of extending the vignette about the calibration curve determination after I had read it a couple of times and still struggled to understand its purpose and certain steps. In particular, I felt that the threshold integration was too brief and even misleading. It really gave me a headache, and I understood only what was done after I looked up the code (contrary to the other vignette, which reads great).

I hope my changes make it more intelligible and provide better information to the users. Please know that my feedback is solely aimed at enhancing the document's clarity and understanding.

@nfrerebeau, please feel free to update specific parts of the text where you see fit.

Details

  • Title change
  • Extension of the text and add more explanations to the
  • Splitting the R code in more chunks
  • Adding references
  • Updating bibliography.bib

@nfrerebeau nfrerebeau merged commit 2f29143 into crp2a:master Aug 22, 2024
7 checks passed
@nfrerebeau
Copy link
Member

Thanks a lot @RLumSK! We implemented all this based on the lab's undocumented spreadsheet... I can confirm that it was enough to give us headaches 😅 !

@RLumSK RLumSK deleted the vignette_update branch August 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants