Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new support for Kromek SPE files #28

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

RLumSK
Copy link
Collaborator

@RLumSK RLumSK commented Aug 20, 2024

The Kromek CZT detectors export a rather unusual ASCII format SPE files that cannot be imported with 'rxylib'. Adding this functionality here was easier than writing C++ code.

Notes

  • @nfrerebeau I've added myself as an author to the package. If you feel that this too much, please just degrade me to contributor.
  • This is a beta version implementation; I have to work more with the package, eventually I will update this implementation.

Description

  • ad update to read.R with code for the import
  • up method definition to handle SPE files
  • ad NEWS
  • ad extdata/Kromek_CZT.spe file
  • up DESCRIPTION and add me as author
  • up manual
  • ad test for the import
  • up test fpr the calibration
  • up fact splot checks

Related Issue

Not applicable

Example

spe_file <- system.file("extdata/Kromek_CZT.spe", package = "gamma")
spe_spectrum <- read(spe_file)

RLumSK added 3 commits August 20, 2024 16:45
+ ad update to read.R with code for the import
+ up method definition to handle SPE files
+ ad NEWS
+ ad extdata/Kromek_CZT.spe file
+ up DESCRIPTION and add me as author
+ up manual
+ ad test for the import
+ up test fpr the calibration
+ up fact splot checks
@nfrerebeau nfrerebeau added the enhancement New feature or request label Aug 21, 2024
@nfrerebeau nfrerebeau merged commit 33e0d9e into crp2a:master Aug 21, 2024
7 checks passed
@nfrerebeau
Copy link
Member

@RLumSK cool! Do you need a new (CRAN) release with this new functionality, or can it wait until this fall?

@RLumSK
Copy link
Collaborator Author

RLumSK commented Aug 21, 2024

Thanks @nfrerebeau. No, it can wait until fall. I am using it actively now, but before the manuscript work is done it may take some time (it can be release later regardless). More time is better, because it allows to spot some additional bugs.

  • For instance, I realised that the GammaSpectrum-class does not hold a slot for comments/description. This we may want to add.
  • I also have to double check the 'real time' and 'live time' to ensure that I did not mix the two up (only the new format)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants