Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module google.golang.org/protobuf to v1.33.0 [security] (release-1.14) #5592

Open
wants to merge 1 commit into
base: release-1.14
Choose a base branch
from

Conversation

crossplane-renovate[bot]
Copy link
Contributor

@crossplane-renovate crossplane-renovate bot commented Apr 17, 2024

This PR contains the following updates:

Package Type Update Change
google.golang.org/protobuf require minor v1.31.0 -> v1.33.0

Infinite loop in JSON unmarshaling in google.golang.org/protobuf

CVE-2024-24786 / GHSA-8r3f-844c-mc37 / GO-2024-2611

More information

Details

The protojson.Unmarshal function can enter an infinite loop when unmarshaling certain forms of invalid JSON. This condition can occur when unmarshaling into a message which contains a google.protobuf.Any value, or when the UnmarshalOptions.DiscardUnknown option is set.

Severity

Unknown

References

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).


Golang protojson.Unmarshal function infinite loop when unmarshaling certain forms of invalid JSON

CVE-2024-24786 / GHSA-8r3f-844c-mc37 / GO-2024-2611

More information

Details

The protojson.Unmarshal function can enter an infinite loop when unmarshaling certain forms of invalid JSON. This condition can occur when unmarshaling into a message which contains a google.protobuf.Any value, or when the UnmarshalOptions.DiscardUnknown option is set.

Severity

Moderate

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

protocolbuffers/protobuf-go (google.golang.org/protobuf)

v1.33.0

Compare Source

This release contains one security fix:

  • encoding/protojson: Unmarshal could enter an infinite loop when unmarshaling certain forms of invalid JSON. This condition can occur when unmarshaling into a message which contains a google.protobuf.Any value, or when the UnmarshalOptions.DiscardUnknown option is set. Unmarshal now correctly returns an error when handling these inputs. This is CVE-2024-24786.

v1.32.0

Compare Source

Full Changelog: protocolbuffers/protobuf-go@v1.31.0...v1.32.0

This release contains commit protocolbuffers/protobuf-go@bfcd647, which fixes a denial of service vulnerability by preventing a stack overflow through a default maximum recursion limit. See https://github.com/golang/protobuf/issues/1583 and https://github.com/golang/protobuf/issues/1584 for details.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@crossplane-renovate
Copy link
Contributor Author

crossplane-renovate bot commented Apr 17, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.mod
Command failed: make generate
# github.com/bufbuild/buf/private/pkg/protodescriptor
/go/pkg/mod/github.com/bufbuild/[email protected]/private/pkg/protodescriptor/protodescriptor.go:52:24: cannot use fileDescriptorProto (variable of type *descriptorpb.FileDescriptorProto) as FileDescriptor value in assignment: *descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
		have GetEdition() descriptorpb.Edition
		want GetEdition() string
/go/pkg/mod/github.com/bufbuild/[email protected]/private/pkg/protodescriptor/protodescriptor.go:71:32: impossible type assertion: fileDescriptor.(*descriptorpb.FileDescriptorProto)
	*descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
		have GetEdition() descriptorpb.Edition
		want GetEdition() string
/go/pkg/mod/github.com/bufbuild/[email protected]/private/pkg/protodescriptor/protodescriptor.go:97:33: cannot use proto.String(edition) (value of type *string) as *descriptorpb.Edition value in assignment
/go/pkg/mod/github.com/bufbuild/[email protected]/private/pkg/protodescriptor/protodescriptor.go:151:36: cannot use fileDescriptorProto (variable of type *descriptorpb.FileDescriptorProto) as FileDescriptor value in argument to ValidateFileDescriptor: *descriptorpb.FileDescriptorProto does not implement FileDescriptor (wrong type for method GetEdition)
		have GetEdition() descriptorpb.Edition
		want GetEdition() string
apis/generate.go:73: running "go": exit status 1
make[1]: *** [build/makelib/golang.mk:240: go.generate] Error 1
make: *** [build/makelib/common.mk:434: generate] Error 2

@crossplane-renovate crossplane-renovate bot force-pushed the renovate/release-1.14-go-google.golang.org/protobuf-vulnerability branch from f603762 to 58a468a Compare April 17, 2024 09:48
@crossplane-renovate crossplane-renovate bot force-pushed the renovate/release-1.14-go-google.golang.org/protobuf-vulnerability branch from 58a468a to 4972380 Compare April 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants