New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RankN function when n greater than 10 #1

Merged

cristaloleg merged 1 commit into cristalhq:main from danghh-1998:main

Jun 24, 2024

Contributor

danghh-1998 commented Jun 24, 2024

First of all, I would like to express my gratitude for the usefulness of this library. It has been incredibly helpful in my projects.

I am using the function RankN, i had a bug

ranks, err := lexorank.RankN("0", "z", 20)
// It return U0, U1, U2, U3, U4, U5, U6, U7, U8, U9, U10, U11, U12, U13, U14, U15, U16, U17, U18, U19
// Expect: U00, U01, U02, U03, U04, U05, U06, U07, U08, U09, U10, U11, U12, U13, U14, U15, U16, U17, U18, U19

So i am submitting this pull request to fix this issue.


          Fix RankN function when n greater than 10

d1471df

cristaloleg approved these changes

View reviewed changes

cristaloleg merged commit a07818e into cristalhq:main

2 checks passed

Member

cristaloleg commented Jun 24, 2024

Thank you for the kind words and precise fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet