Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plume AggregateToken integration test #173

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ChaiSomsri96
Copy link
Contributor

@ChaiSomsri96 ChaiSomsri96 commented Nov 11, 2024

Integration testing between Plume's AggregateToken and LiquidContinuousMultiTokenVault

  • Test the buyComponentToken function
  • Test the sellComponentToken function

@ChaiSomsri96 ChaiSomsri96 requested a review from lucasia November 11, 2024 11:51
Copy link
Member

@lucasia lucasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, thank you!

big one is around updating our compiler version. i don't think we want to do this across the board. let's discuss.

@@ -3,7 +3,7 @@ src = "src"
out = "out"
libs = ["lib"]
fs_permissions = [{ access = "read-write", path = "./" }]
solc_version="0.8.23"
solc_version="0.8.26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ChaiSomsri96 - i don't think we want to bump this across our entire repo. let's discuss.

packages/contracts/test/src/plume/AggregateTokenTest.t.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants