-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plume AggregateToken integration test #173
base: main
Are you sure you want to change the base?
Conversation
Run The UI With The Newly Deployed Contracts
aggregate-token-modifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, thank you!
big one is around updating our compiler version. i don't think we want to do this across the board. let's discuss.
@@ -3,7 +3,7 @@ src = "src" | |||
out = "out" | |||
libs = ["lib"] | |||
fs_permissions = [{ access = "read-write", path = "./" }] | |||
solc_version="0.8.23" | |||
solc_version="0.8.26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ChaiSomsri96 - i don't think we want to bump this across our entire repo. let's discuss.
Integration testing between Plume's
AggregateToken
andLiquidContinuousMultiTokenVault
buyComponentToken
functionsellComponentToken
function