Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restyled project list page #901

Open
wants to merge 4 commits into
base: vocab-refresh
Choose a base branch
from
Open

restyled project list page #901

wants to merge 4 commits into from
+26 −20

Conversation

Queen-codes
Copy link
Contributor

Fixes

Description

  • adds datatable display class to the table
  • adds a div with class content body-container for local styling
  • styles featured project section

Screenshots

127 0 0 1_5000_contributing-code_projects_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners January 17, 2025 08:00
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and Cronus1007 and removed request for a team January 17, 2025 08:00
TimidRobot
TimidRobot requested changes Jan 17, 2025
View reviewed changes
assets/static/css/style.css Outdated Show resolved Hide resolved
possumbilities
possumbilities reviewed Jan 17, 2025
View reviewed changes
themes/vocabulary_theme/templates/project_list.html
@@ -8,6 +8,7 @@ <h1>Project List</h1>
<p>This is a list of all active open source software projects that Creative Commons (CC) maintains.</p>
</header>

<div class="content body-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the use of body-container might need adjustment, I try to not reuse the word body so there's not conflicts with the <body> element in docs, etc.

Often I'll use description if that makes sense, or something else.

possumbilities
possumbilities reviewed Jan 17, 2025
View reviewed changes
themes/vocabulary_theme/templates/project_list.html
@@ -38,8 +39,8 @@ <h3><a href="{{ repo.url }}">{{ repo.english_name }}</a></h3>
<div>
<h2>All Active Projects</h2>
<p>This is a complete list of active Creative Commons software projects. Archived projects are not documented here and can be found on the <strong><a href="https://github.com/cc-archive">CC Archive GitHub organization</a></strong>.</p>
<div>
<table>
<div class="table-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the table need a div around it? is it serving a purpose?

@possumbilities
Copy link
Contributor

@Queen-codes I added some comments above, but more generally what are the plans for handling the datatables and any rendering issues for smaller viewports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@possumbilities possumbilities possumbilities left review comments

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@Cronus1007 Cronus1007 Awaiting requested review from Cronus1007 Cronus1007 is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

@TimidRobot TimidRobot Awaiting requested review from TimidRobot

Assignees
No one assigned
Labels
None yet
Projects
TimidRobot
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Queen-codes @possumbilities @TimidRobot