Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restyled community team page tables #898

Merged

Conversation

Queen-codes
Copy link
Contributor

Fixes

Description

  • added datatables to project via cdn
  • add jquery for datatable support via cdn
  • adds a table.js file to initialize datatable in project
  • add local styles to the table(based on current styling on website)
  • add local styles for code blocks(from current styling on website)

Screenshots

127 0 0 1_5000_community_community-team_members_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners January 15, 2025 16:42
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and akmadian and removed request for a team January 15, 2025 16:42
@Queen-codes
Copy link
Contributor Author

Hi @possumbilities, just to confirm my understanding: I would download three files—datatables.css, datatables.js, and jquery—and include them in the vendor directory of vocabulary. Then, I’d use them in the required html files like this:

<script src="{{ '/static/vendor/jquery/jquery-3.7.1.min.js'|url }}"></script>
<script src="{{ '/static/vendor/datatables/dataTables.js'|url }}"></script>

@possumbilities
Copy link
Contributor

@Queen-codes Yes, essentially.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Please see requested changes below:

assets/static/js/table.js Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/community_team_list.html Outdated Show resolved Hide resolved
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thank you!!

@TimidRobot TimidRobot merged commit 6f44550 into creativecommons:vocab-refresh Jan 16, 2025
1 check passed
@TimidRobot TimidRobot linked an issue Jan 16, 2025 that may be closed by this pull request
1 task
@Queen-codes Queen-codes deleted the restyle-community-team-page branch January 17, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Restyle Tables in Community Team Members Page
3 participants