Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restyle CC's open source website to match vocab design feel #888

Merged
merged 13 commits into from
Jan 14, 2025

Conversation

Queen-codes
Copy link
Contributor

@Queen-codes Queen-codes commented Jan 13, 2025

Fixes

Description

  • adds styles to the styles.css file based on the styling from CC's main website (most of the applicable styles were lifted)
  • removes all legacy styling from the homepage contents.lr file
  • add's program-index styling for get involved and featured projects section.

Screenshots

127 0 0 1_5000_ (1)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners January 13, 2025 07:26
@Queen-codes Queen-codes requested review from TimidRobot, possumbilities and akmadian and removed request for a team January 13, 2025 07:26
@TimidRobot TimidRobot self-assigned this Jan 13, 2025
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

In addition to the code comments, please address the spacing between these two paragraphs and the call-to-action links that follow them:
Screenshot 2025-01-13 at 07-47-47 Welcome — Creative Commons Open Source
The spacing makes it look like the links are associated with the content below them instead of above them.

content/contents.lr Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/layout.html Show resolved Hide resolved
themes/vocabulary_theme/templates/blocks/recent-posts.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/blocks/hero.html Outdated Show resolved Hide resolved
content/contents.lr Outdated Show resolved Hide resolved
content/contents.lr Outdated Show resolved Hide resolved
@possumbilities
Copy link
Contributor

possumbilities commented Jan 14, 2025

@Queen-codes After reviewing further we probably would want to have the "recent blog posts" not have a larger featured article, and let them all just be in the equal-sized grid (this should be doable by just not utilizing a feature pseudo-semantic class on that article, and dropping the amount shown to be 4 (to prevent a wrapping line orphan). Additionally, the display order of the various items within each article is currently matching the html markup order, rather than the order change that is present on creativecommons.org/blog (as an example) provided by CSS (so that the markup order remains semantic, but the display order follows the design).

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thank you!

@TimidRobot TimidRobot merged commit 456a852 into creativecommons:vocab-refresh Jan 14, 2025
1 check passed
@Queen-codes Queen-codes deleted the restyle-homepage branch January 15, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants