Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Mar 6, 2025

amotl added 4 commits March 6, 2025 17:51
- Many projects just use a `main.yml` workflow file, if they do not need
  to discriminate between different workflows for different purposes.

- The title can be anything, but in this case let us propose a shorter
  and more concise one: "CI status".
Each push operation to a feature branch would regularly trigger a CI
workflow run. When quickly pushing in succession, the previous runs
become redundant and obsolete instantly, so let's cancel them.
@amotl amotl requested review from kneth and surister March 6, 2025 16:57
@amotl amotl marked this pull request as ready for review March 6, 2025 16:57
types: [published]
workflow_dispatch:
schedule:
- cron: '0 4 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense that we run this every day when we already run on PRs and merges?

Copy link
Member Author

@amotl amotl Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It is about to feed the downstream Build Status page and GitHub Actions reports, that notify us about negative side effects, infrastructure or not, which happen on spots of the time axis other than on-PR, or on-merge.

In this case, it is about validating that the little infrastructure that invokes the test suite, including installing its requirements, does not break. In this case, because the packages listed in requirements.txt do not use version pinning yet, which is fine, it gives us confidency that it will always work, or otherwise that we know before. For example, there would be a signal if the location of tdvt @ git+https://github.com/tableau/connector-plugin-sdk/#subdirectory=tdvt changes, because upstream relocates it.

Maybe it's utter nonsense, still after my explanation attempt, then please let me know about it, and I will remove that cron configuration again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I understand now, didn't think of that, it makes sense, thanks for the explanation!!

@amotl amotl requested a review from surister March 6, 2025 19:18
@surister surister merged commit 3c0ed51 into main Mar 6, 2025
1 check passed
@surister surister deleted the ci-naming-things branch March 6, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants