Maintenance: Add support for Python 3.12 #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
collab/modernize
branch
from
553e58f to
0d34706
Compare
amotl
force-pushed
the
python312
branch
3 times, most recently
from
4a93570 to
dcc4ea1
Compare
1 task
amotl
force-pushed
the
collab/modernize
branch
from
0d34706 to
2ac3d0f
Compare
amotl
force-pushed
the
collab/modernize
branch
4 times, most recently
from
8d50802 to
de87095
Compare
amotl
force-pushed
the
python312
branch
2 times, most recently
from
d5fdb02 to
b46f806
Compare
amotl
commented
Feb 19, 2025
Comment on lines
+530
to
+535
| node_index = int(next_pod_name[next_pod_name.rindex("-") + 1 :]) | ||
| node_progress = f"{node_index + 1}/{len(all_pod_uids)}" | ||
| await send_operation_progress_notification( | ||
| namespace=namespace, | ||
| name=name, | ||
| message="Waiting for node " | ||
| f"{int(next_pod_name[next_pod_name.rindex('-')+1:])+1}/{len(all_pod_uids)}" | ||
| " to be restarted...", | ||
| message=f"Waiting for node {node_progress} to be restarted.", |
There was a problem hiding this comment.
This update is just because of line length limitations, now raised by the flake8 linter, after updating it.
Cutting the statements in the middle of the string interpolation feels nasty, so we did it this way, separating the statements from each other.
This comment was marked as outdated.
This comment was marked as outdated.
|
I've just refreshed the patch. 🍀 |
|
it looks good to me, but I'll let @tomach have the last word (because he is more aware of that topic than me). |
LGTM! doesn't seem to have any behavioral changes. |
tomach
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Make the operator support Python 3.12.
Blocked by