Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for various bugs (scrollbar, focus, cascades), style improvements #560

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Fixes for various bugs (scrollbar, focus, cascades), style improvements #560

merged 7 commits into from
Dec 13, 2024

Conversation

msbt
Copy link
Collaborator

@msbt msbt commented Dec 12, 2024 •
edited by amotl
Loading

Summary of the changes / Why this is an improvement

  • Fix some regressions from Furo (Algolia focus)
  • Remove input focus (inherited from Furo)
  • CLS fix from Algolia implementation
  • Reposition code block (didn't cascade right)
  • Add horizontal scrolling to tables on mobile to avoid having layouts wider than the screen
  • Keep iframe embeds from having a layout wider than the screen by adding max-width
  • Fix scrollbar light-colors on Chromium browsers and different modes
  • Use <html> instead of <body> as target for dark/light mode data-theme attributes

Demo: https://crate-docs-theme--560.org.readthedocs.build/en/560/

@msbt msbt requested a review from amotl December 12, 2024 09:49
amotl
amotl approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. :shipit: ?

@msbt
Copy link
Collaborator Author

msbt commented Dec 12, 2024

@amotl would be great, as long as @proddata gave it another whirl to see if my changes didn't kill anything ;)

@amotl amotl merged commit 430049d into main Dec 13, 2024
8 checks passed
@amotl amotl deleted the matthias/style-updates branch December 13, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

@proddata proddata proddata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbt @amotl @proddata