-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Version Chooser: Integrate most recent changes from pydata-sphinx-theme
> 1. don't return false, use event.prevent_default() instead > 2. the fetch().then().catch() pattern you've copied here doesn't actually work as > advertised. See the updated logic, which includes an if (head.ok) conditional to > distinguish between "successful fetch of desired head (2xx response)" versus > "successful fetch of the 404 page (4xx response)". The catch clause is still needed to > handle genuine errors (like the fetch being blocked by CORS policy). Thank you, @drammock.
- Loading branch information
Showing
2 changed files
with
16 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters