Add SQLAlchemy model definition class to complete the implementation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -35,6 +36,10 @@ | |||
|
|
|||
| @patch("crate.client.connection.Cursor", FakeCursor) | |||
| def test_table_with_object_array(db): | |||
| class DummyTable(db.Base): | |||
Check notice
Code scanning / CodeQL
Unused local variable
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The code works without issues, tests succeed.
However, when adding a SQLAlchemy model definition class, in order to complete the implementation, CodeQL will raise a notice that the code would sport an unused variable. The corresponding rule is
py/unused-local-variable.Thoughts
While CodeQL is right, the code is also right. Is there a way to annotate such code that CodeQL will accept it without further ado?
References