fixed valet-dns bash and going off line problem

[jesusalc]

I fixed several bash errors
But I would like discuss and then apply fix for "offline valet problem"
This is the bit the results in removing communication from the outside world.
Does anyone knows more about this piece of code ?
These are my observations

in valet-dns

right after line 63

symlinkResolv

# @WHY ?
# This line under creates an empty file ...why ?
# why:   cat "${FILES[@]}" | grep -v '^nameserver' | grep -v '^#' | unique | tee "$VRESOLV" &>/dev/null
#      = same  grep -v '^nameserver' "${FILES[@]}" | grep -v '^#' | unique | tee "$VRESOLV" &>/dev/null
# And this line then adds 127 alone into the resolv.conf
# why: echo 'nameserver 127.0.0.1' >> "$VRESOLV"
# the result in localhost is to efectively remove all access to the
# outsite world
# I would like to know what is the expectation and why is this like
# this

# I suggest passing local 127 first when creating the resolv.conf
echo 'nameserver 127.0.0.1' > "$VRESOLV"
# Here are appending the gateway given by the network interface
# to keep laptop online
# I don't why we need t remove any comments ?
grep -E '^nameserver|^#' "${FILES[@]}" | unique | tee -a "$VRESOLV" &>/dev/null

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jmarcher]

This regex seems incorrect

[jesusalc]

is it the \d you are referring to? I cannot remember why I removed. Need to check again

[jmarcher]

Can you remove this comments (there are a lot of typos) and explain why are you changing this. I do not understand why we need this...

[jesusalc]

My understanding has been that we need this line for the resolv DNS to work, it seems that not all Linux are working the same. So, I found other users complain about how "after valet" internet connectivity is gone, I had the same issue. But it was very random. That means that sometimes it will work, and sometimes it will fail. This line seems to fix the issue. That is why I added the comments. Which I don't mind removing. But perhaps some one else can validate this concept ?

[jmarcher]

Why remove the echo?

[jesusalc]

Here is a "useless echo" you don't need "echo" wrap the output of a sub-process only calling grep, was there a special reason for that? From this side of the woods, echo was not needed, unless I am missing something, then I am open to learn about it.

[jmarcher]

Why is this change needed?

[jesusalc]

I am guessing you are referring to this "change" to "change." From my experience, it is good practice to use "" to indicate that a variable is not going to be used. Normally, in other languages that is the practice. But in Bash many programmers use "" are internal variables, so for non-used then add double "". So the shell check linker can also ignore it.