Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ECM and KSH submodules #1323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Feb 18, 2024

Description

Remove ECM and KSH submodules and clone them in CI.

Related Issues / Pull Requests

#1322

@ouuan ouuan changed the base branch from master to v7.0 February 18, 2024 15:21
@coder3101
Copy link
Member

coder3101 commented Jun 1, 2024

We should not build the KSH or ECM in CI rather use package managers to install them. We are going with upgrading to qt6 and KF5* packages such as syntax-higlighting needs qt5.

  • For macOS, we can use the official homebrew tap
  • For Ubuntu, libkf5syntaxhighlighting-dev package should work
  • For Windows, we can use craft but I haven't tried this nor do I have a windows machine.

@coder3101 coder3101 changed the base branch from v7.0 to master June 1, 2024 09:23
@coder3101
Copy link
Member

macOS builds are failing because of architecture mismatch. GH has rolled out arm64 with macos-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants