Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update cozy-harvest-lib from 6.7.3 to 17.0.0 #2483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Aug 2, 2023

Following the update of some subdependencies, the baseDir parameter of the bundlemon configuration no longer works if it is not filled in or simply with "." or "./".
The transpiled/react folder now having only components, it is more relevant that it is on the application side that the components are monitored by Bundlemon.

BREAKING CHANGE: Moved the stylesheet.css file to the dist folder, in order to group the style files.
You must change your import:
import 'cozy-ui/transpiled/react/stylesheet.css' by import 'cozy-ui/dist/stylesheet.css'

BREAKING CHANGE: you must have cozy-harvest-lib >= 17.0.0 & cozy-client >= 40.2.0
To benefit from the fix cozy/cozy-libs@920f9d2

@Merkur39 Merkur39 force-pushed the feat/update-cozy-harvest-lib-to-17.0.0 branch 6 times, most recently from 69dc702 to 3eafcc2 Compare August 3, 2023 11:14
@cozy cozy deleted a comment from bundlemon bot Aug 3, 2023
@cozy cozy deleted a comment from argos-ci bot Aug 3, 2023
@Merkur39 Merkur39 force-pushed the feat/update-cozy-harvest-lib-to-17.0.0 branch 5 times, most recently from a24370a to bdf9418 Compare August 4, 2023 09:27
@cozy cozy deleted a comment from bundlemon bot Aug 4, 2023
@Merkur39 Merkur39 force-pushed the feat/update-cozy-harvest-lib-to-17.0.0 branch from bdf9418 to 9dc8e51 Compare August 4, 2023 10:04
@bundlemon
Copy link

bundlemon bot commented Aug 4, 2023

BundleMon

Files added (3)
Status Path Size Limits
cozy-ui.min.css
+19.72KB +10%
stylesheet.css
+19.13KB +10%
cozy-ui.utils.min.css
+10.49KB +10%
Files removed (3)
Status Path Size Limits
dist/cozy-ui.min.css
-19.72KB -
transpiled/react/stylesheet.css
-19.13KB -
dist/cozy-ui.utils.min.css
-10.49KB -

No change in files bundle size

Groups removed (1)
Status Path Size Limits
transpiled/react/**
-627.62KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Collaborator

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce que l'approche a été validé avec @Crash-- ?

.travis.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@Merkur39 Merkur39 force-pushed the feat/update-cozy-harvest-lib-to-17.0.0 branch 2 times, most recently from aca557f to 31413ba Compare August 8, 2023 13:33
 BREAKING CHANGE: Moved the `stylesheet.css` file to the `dist` folder, in order to group the style files.

You must change your import:
`import 'cozy-ui/transpiled/react/stylesheet.css'`
by:
`import 'cozy-ui/dist/stylesheet.css'`
BREAKING CHANGE: you must have `cozy-harvest-lib >= 17.0.0` &
`cozy-client >= 40.2.0`
To benefit from the fix cozy/cozy-libs@920f9d2
Following the update of some subdependencies,
the `baseDir` parameter of the bundlemon
configuration no longer works if it is not filled in
or simply with `"."` or `"./"`.

The `transpiled/react` folder now having only
components, it is more relevant that it is on the
application side that the components are monitored by Bundlemon.
@Merkur39 Merkur39 force-pushed the feat/update-cozy-harvest-lib-to-17.0.0 branch from 31413ba to bc36880 Compare August 9, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants