feat: Add FilePicker component #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Dec 21, 2021
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
706d134
to
5191f01
Compare
Merkur39
force-pushed
the
feat/FilePicker
branch
from
5191f01
to
76891bd
Compare
Ldoppea
reviewed
Jan 4, 2022
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
2079362
to
5b50000
Compare
|
@Merkur39 is it ready to review? Do you still work to do on it? |
Excuse me, there is still some work to be done :) |
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
5d5f0a3
to
7d23ff0
Compare
|
Oui, les dossiers on une zone de sélection défini par le Divider vertical, car il faut que l'on puisse toujours naviguer dans l'arborescence.
En effet, je vais creuser un peu, pas si simple qu'il n'y parait 😁 |
Je m'en doutais :p j'ai failli mettre un "si pas trop compliqué" mais en fait ce serait quand même mieux pour tester et blinder la feature |
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
54a51cc
to
aeca351
Compare
|
Documentation enrichie 👍 |
JF-Cozy
reviewed
Jan 19, 2022
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
a932bc2
to
3f2de39
Compare
trollepierre
approved these changes
Jan 19, 2022
Crash--
reviewed
Jan 19, 2022
Crash--
reviewed
Jan 19, 2022
Crash--
reviewed
Jan 19, 2022
Crash--
reviewed
Jan 19, 2022
Merkur39
force-pushed
the
feat/FilePicker
branch
2 times, most recently
from
295d75b
to
0b0c59b
Compare
JF-Cozy
approved these changes
Jan 20, 2022
Inspired by MoveTo on Drive. FilePicker allows to select a file or a folder in Drive a single or multiple way and returns an array of id of the selected items
Merkur39
force-pushed
the
feat/FilePicker
branch
from
0b0c59b
to
8f64520
Compare
|
🎉 This PR is included in version 60.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by MoveTo on Drive.
FilePicker allows to select a file or a folder in Drive a single or multiple way and returns an array of id of the selected items
In the case of a single selection, the selection does not need to be confirmed
Demo: https://merkur39.github.io/cozy-ui/react/#!/FilePicker/1
This will be a first operational version.
Future evolutions may follow:
#2017
#2018
...