feat: Remove cordova methods from cozy-device-helper #2664
+9
−647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
force-pushed
the
feat/clean-cordova-logic
branch
2 times, most recently
from
7c57ad4 to
e80d2e7
Compare
zatteo
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
doubleface
as code owners
BREAKING CHANGE: Every cordova related methods have been removed. When updating, if you find a method below, it is probably dead code that you can remove. : - hasDevicePlugin, - hasInAppBrowserPlugin, - hasSafariPlugin, - hasNetworkInformationPlugin - checkApp - startApp - nativeLinkOpen - openDeeplinkOrRedirect - getDeviceName When updating, if you find a method below, keep what is relevant, i.e. what is related to `isWebApp()` or `!isMobileApp()` or `!isCordova()` : - isCordova - getPlatform - isIOSApp - isAndroidApp - isMobileApp - isWebApp
zatteo
force-pushed
the
feat/clean-cordova-logic
branch
from
e80d2e7 to
2599635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.