Feat/Add latest national ID card version in OCR process #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rotated file is saved in the "formData" state only once we move on to the next step, and not at each rotation. The state of the "formData" is therefore not up to date if the last file added has been rotated.
Merkur39
force-pushed
the
feat/697
branch
3 times, most recently
from
777f598
to
c7f49e7
Compare
In view of future developments, it is preferable to separate the responsibilities of each helper. It was also discussed with @paultranvan to change the type of the `ocrAttributes` attribute in the config file, for more flexibility.
This modal comes after the animated OCR processing modal, to ask the user to confirm the recognized version.
This introduces a new 'stripChars' method in validationRules, useful to remove extra characters from the regex. Those characters are useful for detection, but should be removed afterwards.
This is the french identity card format, created in march 21. By @paultranvan
This introduces the possibility to detect a paper version, based on the 2 sides OCR + reference rules. Those rules can be applied on front and/or back side. All the rules must be respected in order to detect a version. For now, the rules are simple regex, evaluated against the OCR. By @paultranvan
Merkur39
force-pushed
the
feat/697
branch
2 times, most recently
from
56e2350
to
a977bba
Compare
JF-Cozy
approved these changes
Dec 14, 2023
packages/cozy-mespapiers-lib/src/components/ModelSteps/helpers.js
Outdated
Show resolved
Hide resolved
packages/cozy-mespapiers-lib/src/components/ModelSteps/ScanResult/OcrProcessingDialog.jsx
Show resolved
Hide resolved
packages/cozy-mespapiers-lib/src/components/ModelSteps/ScanResult/SelectPaperFormat.jsx
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,17 @@ import log from 'cozy-logger' | |||
| const MAX_TEXT_SHIFT_THRESHOLD = 5 // in % | |||
| const MAX_LINE_SHIFT_THRESHOLD = 5 // in px | |||
|
|
|||
| const normalizeText = text => { | |||
| // TODO: more normalization might be necessary | |||
There was a problem hiding this comment.
y'a t-il un todo à faire, ou faut-il modifier le commentaire pour être plus explicite ?
There was a problem hiding this comment.
Le TODO est pour là pour plus tard justement, il pourrait il y avoir des besoins supplémentaires de normalisation, mais je préfère les ajouter au fil de l'eau plutôt qu'en faire trop et tomber sur des effets de bords non maîtrisés
packages/cozy-mespapiers-lib/src/components/ModelSteps/ScanResult/SelectPaperFormat.jsx
Outdated
Show resolved
Hide resolved
By being too strict on the validation rules, we were sometimes missing the recognition, typically because of a '0' interpreted as a 'O'.
We are now more flexible on the date post-validation format, by using date-fns parse method. We also try/catch the method to avoid crashes when the date format is wrong.
Those additional regex rules are quite useful for number and expiration date attributes, as the passport is hard to correctly scan, leading to detection failures for boxes detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR ajoute lors de l'OCR la possibilité de gérer plusieurs versions d'un même document.
Ce changement à mené à repenser, avec @paultranvan, à certaines implémentations, autant dans la configuration du fichier
papersDefinitions.json, que dans quelques fonctions existantes.Côté UI/UX, nous ajoutons un nouvel écran à la suite de l'écran du traitement OCR, pour demander à l'utilisateur de confirmer la version reconnue.
Et c'est à la suite de cette confirmation que nous extrayons les bonnes données, et affichons la suite du process.