Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cozy-harvest-lib): Remove dead code #1890

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Nov 28, 2022

Warning
Do not merge this PR before #1888 is merged and deployed as we don't want to destabilize the next release


withKonnectorModal(), getUserConfig() and updateUserConfig() seem not to be used anywhere

So this commit removes them to simplify the code

All those three methods where detected to be dead code because they are related to the createTemporaryToken investigation done in #1888

Some other dead code may remain

`withKonnectorModal()`, `getUserConfig()` and `updateUserConfig()` seem
not to be used anywhere

So this commit removes them to simplify the code

All those three methods where detected to be dead code because they are
related to the `createTemporaryToken` investigation done in #1888

Some other dead code may remain
@Ldoppea Ldoppea force-pushed the chore/remove_dead_code branch from ed83e57 to 4a4cfc1 Compare November 28, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant