feat: Open cozy-app when offline only if it supports Offline mode #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zatteo
reviewed
Sep 16, 2024
| ) | ||
| const isOffflineCompatitble = await isOfflineCompatible(fqdn, slug) | ||
|
|
||
| if (!isOffflineCompatitble && slug !== 'home') { |
There was a problem hiding this comment.
Why the special case for home ?
Ldoppea
force-pushed
the
feat/make_offline_readonly
branch
from
608539f
to
53df8f4
Compare
Ldoppea
force-pushed
the
feat/open_only_compatible_apps
branch
3 times, most recently
from
40f24ca
to
35e7c9a
Compare
Ldoppea
changed the base branch from
feat/make_offline_readonly
to
feat/offline_error_screen
Ldoppea
force-pushed
the
feat/open_only_compatible_apps
branch
from
35e7c9a
to
8e624d4
Compare
When offline, we want to open coz-apps only when they declare to be compatible with Offline mode Cozy-app can declare this by setting `offline_support: true` in their manifest.webapp file Non compatible cozy-app won't be opened when the Flagship app is offline, and instead an error message will be displayed
Ldoppea
force-pushed
the
feat/offline_error_screen
branch
from
2f518b6
to
d411dc6
Compare
Ldoppea
force-pushed
the
feat/open_only_compatible_apps
branch
from
8e624d4
to
1cca1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When offline, we want to open coz-apps only when they declare to be compatible with Offline mode
Cozy-app can declare this by setting
offline_support: truein their manifest.webapp fileNon compatible cozy-app won't be opened when the Flagship app is offline, and instead an error message will be displayed