Add logs and fixes a race condition in CryptoWebView #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forward errors from CryptoWebView to React Native side to log them - Add a title to CryptoWebView to help finding it on Chrome debugger
zatteo
commented
Sep 3, 2024
| @@ -23,6 +23,8 @@ const jsCode = ` | |||
| generateHttpServerSecurityKey, | |||
| sublteProxy | |||
| } | |||
|
|
|||
| postMessage(JSON.stringify({ isReady: true })) | |||
There was a problem hiding this comment.
Si on ralentit le code au début de ce jsCode avec une boucle qui tourne pour rien, onLoadEnd peut se déclencher beaucoup trop tôt.
We use react-native-webview onLoadEnd callback to set the CryptoWebView as ready. It is an important action because other webviews are rendered only when the CryptoWebView is ready. But the onLoadEnd can be triggered before the javascript, where we add our crypto functions, is executed. It is also executed two times (I do not understand why). So here I send a post message from the CryptoWebView to indicate that it is ready. It fixes a race condition we may encounter more and more.
zatteo
force-pushed
the
fix/error-in-crypto-webview
branch
from
e4a0975
to
4c7939c
Compare
Ldoppea
approved these changes
Sep 4, 2024
Ldoppea
reviewed
Sep 4, 2024
ios/Podfile.lock
Outdated
| @@ -1025,7 +1025,7 @@ EXTERNAL SOURCES: | |||
| :path: "../node_modules/react-native/ReactCommon/yoga" | |||
|
|
|||
| SPEC CHECKSUMS: | |||
| boost: 57d2868c099736d80fcd648bf211b4431e51a558 | |||
| boost: 7dcd2de282d72e344012f7d6564d024930a6a440 | |||
There was a problem hiding this comment.
This one should be removed from the PR?
zatteo
force-pushed
the
fix/error-in-crypto-webview
branch
from
4c7939c
to
c6687d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Before merging this PR, the following things must have been done if relevant: