feat: Allow cozy-apps to access files offline #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2024
zatteo
reviewed
Sep 2, 2024
| setDownloadProgress?.(progressPercent) | ||
| }, | ||
| progressInterval: 100 | ||
| }).promise |
There was a problem hiding this comment.
Maybe extract the download logic like we did for the upload ? https://github.com/cozy/cozy-flagship-app/tree/master/src/app/domain/upload/services
zatteo
reviewed
Sep 2, 2024
|
|
||
| if (files.has(fileId)) { | ||
| return files.get(fileId) | ||
| } |
There was a problem hiding this comment.
Do we need the .has() ? .get() returns undefined if it does not exists.
zatteo
reviewed
Sep 2, 2024
| log.debug( | ||
| `Remove old unimportant file ${ | ||
| offlineFile.id | ||
| } (last opened on ${lastOpened.toString()})` |
There was a problem hiding this comment.
Is there a risk to have an error here if lastOpened is undefined ? Seems no, I read the code below
1 task
Ldoppea
force-pushed
the
feat/open_offline
branch
from
bcf0320
to
289a7b9
Compare
Ldoppea
force-pushed
the
feat/files_offline
branch
from
71229ad
to
f13cd52
Compare
Ldoppea
force-pushed
the
feat/open_offline
branch
from
289a7b9
to
27ed108
Compare
Ldoppea
force-pushed
the
feat/files_offline
branch
from
f13cd52
to
cceb2b7
Compare
When the application is offline, we want the user to be able to access their files that are accessible offline To make this possible, we want the Flagship app to provide a new `downloadFileAndPreview()` interface that can be called from cozy-apps Internally this method should allow to download and preview files, but also to store them in the device's storage in order to make them accessible later even when the app is offline This method will be called from cozy-client through `file` model For now we make files accessible only if they have already downloaded once In the following commit we will make important files accessible in a proactive way
We want the user's important files to always be accessible offline To make this possible, we want the app to download them in background on startup We consider important files as files from `mespapiers` with specific qualification labels like passport, identification papers, vehicle registration, etc.
As we store offline accessible files in the device's storage, we want to prevent them to fill the entire device's storage We chose to keep only files that were accessed in the previous month. All other files would be deleted Important files are never deleted as long as they exist on the Cozy instance
Ldoppea
force-pushed
the
feat/open_offline
branch
from
27ed108
to
749ef40
Compare
Ldoppea
force-pushed
the
feat/files_offline
branch
from
cceb2b7
to
5a9d0ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application is offline, we want the user to be able to access their files that are accessible offline
To make this possible, we want the Flagship app to provide a new
downloadFileAndPreview()interface that can be called from cozy-appsInternally this method should allow to download and preview files, but also to store them in the device's storage in order to make them accessible later even when the app is offline
This method will be called from cozy-client through
filemodelFor now we make files accessible only if they have already downloaded
once
We also want the user's important files to always be accessible offline
To make this possible, we want the app to download them in background on startup
We consider important files as files from
mespapierswith specific qualification labels like passport, identification papers, vehicle registration, etc.Finally, as we store offline accessible files in the device's storage, we want to prevent them to fill the entire device's storage
We chose to keep only files that were accessed in the previous month. All other files would be deleted
Important files are never deleted as long as they exist on the Cozy instance
TODO: